Fix unhandledrejection event shape
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d32379d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
javivelasco
force-pushed
the
fix/unhandled-rejections-event
branch
from
5e9ab24 to
5b9ea6d
Compare
javivelasco
force-pushed
the
fix/unhandled-rejections-event
branch
from
61baafd to
14ad95f
Compare
javivelasco
force-pushed
the
fix/unhandled-rejections-event
branch
from
a3eed79 to
f2c1457
Compare
javivelasco
force-pushed
the
fix/unhandled-rejections-event
branch
from
f2c1457 to
d32379d
Compare
Merged
Merged
jridgewell
pushed a commit
to jridgewell/edge-runtime
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently users can add an event listener using
addEventListenerfor theunhandledrejectionevent. This handler is then invoked when an unhandled rejection occurs with an object that contains apromiseand areason. In Node.js the handler has a different signature and takes those two values into separated arguments. Currently we are invoking the handler using the Node.js signature while we should useUnhandledPromiseRejectioninstead. This PR fixes such issue and add some tests to ensure we are invoking the handler when there is an unhandled rejection.