Support additionalProperties in open api schema
#5626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
support-additional-properties-open-api-schema
branch
from
3687f14 to
bd8bc17
Compare
`z.record(z.string())` currently gets converted to `undefined`, which is invalid and causes an error from vertex ai.
This now gets converted to `{ type: 'object', additionalProperties: { type: "string" } }`
tjenkinson
force-pushed
the
support-additional-properties-open-api-schema
branch
from
bd8bc17 to
4d420d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z.record(z.string())as a property in tool parameters currently gets converted toundefined, which is invalid and causes an error from vertex ai.This now gets converted to
{ type: 'object', additionalProperties: { type: 'string' } }, which worksfixes #5628