Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precise error conditions to verifier unit tests #136

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

yogeshbdeshpande
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande commented Feb 20, 2023

Fixes #118

Signed-off-by: Yogesh Deshpande yogesh.deshpande@arm.com

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #136 (d22cf41) into main (c6971fb) will not change coverage.
The diff coverage is n/a.

❗ Current head d22cf41 differs from pull request most recent head bf07ad7. Consider uploading reports for the commit bf07ad7 to get more accurate results

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          10       10           
  Lines         978      978           
=======================================
  Hits          901      901           
  Misses         51       51           
  Partials       26       26           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yogeshbdeshpande yogeshbdeshpande marked this pull request as ready for review February 20, 2023 13:07
verifier_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fixes #118

Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit Test in go-cose repository needs to check for precise error condition
3 participants