Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added issue templates #132

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Conversation

toddysm
Copy link
Collaborator

@toddysm toddysm commented Feb 10, 2023

Signed-off-by: Toddy Mladenov toddysm@gmail.com

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #132 (9edaddb) into main (8dc4423) will increase coverage by 0.95%.
The diff coverage is n/a.

❗ Current head 9edaddb differs from pull request most recent head 75ac28f. Consider uploading reports for the commit 75ac28f to get more accurate results

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   91.82%   92.77%   +0.95%     
==========================================
  Files          10       10              
  Lines         978     1024      +46     
==========================================
+ Hits          898      950      +52     
+ Misses         54       49       -5     
+ Partials       26       25       -1     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm toddysm requested review from SteveLasker and yogeshbdeshpande and removed request for SteveLasker and yogeshbdeshpande February 22, 2023 01:43
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-cose is under MPL, based on its history.

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-or-issue.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature-request.yaml Outdated Show resolved Hide resolved
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm toddysm requested review from SteveLasker and removed request for yogeshbdeshpande February 27, 2023 16:38
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @toddysm

Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly address these comments

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SteveLasker SteveLasker merged commit 134c56b into veraison:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants