Unix CLI: Don't initially re-ask PIM if it was already specified #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to reset PIM in PasswordException as it is immediately fell back to if PIM is specified in text mode, but password is not. This causes an exception that resets the PIM when it shouldn't.
|
Thank you for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to reset PIM in PasswordException as it is immediately fell back to if PIM is specified in text mode, but password is not. This causes an exception that resets the PIM when it shouldn't. If a password is given incorrectly, we still get caught by PasswordIncorrect and PIM is correctly reset to -1 as proposed and implemented in eb61010 based on #1026.
Fixes #1286