Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Roles were not resolved on User entity #3011

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix(core): Roles were not resolved on User entity #3011

merged 2 commits into from
Aug 19, 2024

Conversation

arrrrny
Copy link
Contributor

@arrrrny arrrrny commented Aug 14, 2024

Description

User Entity was missing the Roles field resolved

Breaking changes

No

Screenshots

Screenshot 2024-08-14 at 10 36 39 AM

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 19, 2024 9:45am

@arrrrny arrrrny mentioned this pull request Aug 14, 2024
Open
michaelbromley
michaelbromley requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to prevent unnecessary code execution

packages/core/src/api/resolvers/entity/user-entity.resolver.ts Outdated Show resolved Hide resolved
@arrrrny
Copy link
Contributor Author

arrrrny commented Aug 19, 2024

done

@michaelbromley michaelbromley merged commit 8f99b2d into vendure-ecommerce:master Aug 19, 2024
14 checks passed
@michaelbromley
Copy link
Member

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelbromley michaelbromley michaelbromley requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arrrrny @michaelbromley