Fix for job cancellation issue #1127 #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
|
Thank you! I'm not totally sure whether this is exactly the same issue as #1127, since this is specific to subscribing to jobs. But a good improvement nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was the root cause why sometimes I were not able to cancel some jobs.
I've created an example job which was running in
setInterval()(not included here). If I subscribe to the job's updates, sometimes it doesn't gave me back the job state after I cancel it.I digged in the source, and find this where I were able to fix the issue for myself. As I've seen that someone else also opened an issue for this, I made the PR.
If you need anything else, please let me know!