Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for assigning Assets to Channels #2478

Open
DanielBiegler opened this issue Oct 21, 2023 · 9 comments
Open

Add UI for assigning Assets to Channels #2478

DanielBiegler opened this issue Oct 21, 2023 · 9 comments

Comments

@DanielBiegler
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Was wondering why I can't see my images. Turns out, per the Docs (nice), Assets are Channel-Aware and need to be assigned.

I assumed you just select them and assign them via some button, but there is none:

image

Theres an argument to be had about automatically assigning assets when assigning products/variants to a new channel?

Describe the solution you'd like
For other props there are buttons:

image

Describe alternatives you've considered
Alternative is programmatically assigning them manually via the api but thats the point - lets not have to do that 😄

mutation assign {
  assignAssetsToChannel(
    input: {
      channelId: "3"
      assetIds: [
        "1"
      ]
    }
  ) {
    id
    name
  }
}

Additional context

Similar issue in regards to Assets and Channels: #2122

@michaelbromley
Copy link
Member

michaelbromley commented Oct 27, 2023

Yes, I agree we should have a UI button to do this in the asset gallery, like the delete button.

Theres an argument to be had about automatically assigning assets when assigning products/variants to a new channel?

This should be the case:

But yes I see that similar logic has not been implemented for collections - thanks for pointing out that issue - I'll fix it.

@michaelbromley
Copy link
Member

/bounty $30

@RutamBhagat
Copy link

RutamBhagat commented Jan 12, 2024

/attempt #2478

Options

@ezhil56x
Copy link

ezhil56x commented Jan 13, 2024

@michaelbromley

I tried setting up Vendure for local development and got the below errors. How can I fix this and make it ready for local development

During DB=sqlite yarn populate I'm getting the below error

EntityNotFoundError [GraphQLError]: error.entity-with-id-not-found
    at new I18nError (/home/ezhil/Desktop/vendure/packages/core/src/i18n/i18n-error.ts:25:9)
    at new EntityNotFoundError (/home/ezhil/Desktop/vendure/packages/core/src/common/error/errors.ts:97:9)
    at AdministratorService.assignRole (/home/ezhil/Desktop/vendure/packages/core/src/service/services/administrator.service.ts:243:19)
    at async AdministratorService.ensureSuperAdminExists (/home/ezhil/Desktop/vendure/packages/core/src/service/services/administrator.service.ts:323:13)
    at async AdministratorService.initAdministrators (/home/ezhil/Desktop/vendure/packages/core/src/service/services/administrator.service.ts:56:9)
    at async InitializerService.onModuleInit (/home/ezhil/Desktop/vendure/packages/core/src/service/initializer.service.ts:52:9)
    at async Promise.all (index 1)
    at async callModuleInitHook (/home/ezhil/Desktop/vendure/node_modules/@nestjs/core/hooks/on-module-init.hook.js:43:5)
    at async NestApplication.callInitHook (/home/ezhil/Desktop/vendure/node_modules/@nestjs/core/nest-application-context.js:223:13)
    at async NestApplication.init (/home/ezhil/Desktop/vendure/node_modules/@nestjs/core/nest-application.js:100:9) {
  path: undefined,
  locations: undefined,
  extensions: { code: 'ENTITY_NOT_FOUND' },
  variables: { entityName: 'Role', id: 1 },
  code: 'ENTITY_NOT_FOUND',
  logLevel: 1
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

And during DB=sqlite yarn start I'm getting the below error when I use superadmin as default username and password

[:server] verbose 1/13/24, 3:24 PM - [Vendure Server] FORBIDDEN: error.forbidden 
[:server] verbose 1/13/24, 3:24 PM - [Vendure Server] FORBIDDEN: error.forbidden 
[:server] verbose 1/13/24, 3:24 PM - [Vendure Server] FORBIDDEN: error.forbidden

@mrkirthi-24
Copy link

mrkirthi-24 commented Jan 15, 2024

/attempt #2478 i am in the waitlist if @RutamBhagat is unassigned.

Algora profile Completed bounties Tech Active attempts Options
@mrkirthi-24 2 bounties from 1 projecty
JavaScript, Python
Cancel attempt

@michaelbromley
Copy link
Member

@ezhil56x look like the issue was introduced with a recent commit. I'm investigating.

michaelbromley added a commit that referenced this issue Jan 15, 2024
@algora-pbc algora-pbc bot removed the 💎 Bounty label Jan 26, 2024
@dlhck dlhck moved this from 📅 Planned to 📦 Backlog in Vendure OS Roadmap Sep 24, 2024
@dlhck dlhck added this to the v3.2 milestone Sep 24, 2024
@dlhck
Copy link
Collaborator

dlhck commented Sep 24, 2024

This should be done together with #2903

@casperiv0
Copy link
Contributor

This should be done together with #2903

Does this mean, this feature will only be completed when #2903 is completed or could it be completed beforehand? In the latter case, I could look into this :)!

@dlhck
Copy link
Collaborator

dlhck commented Nov 27, 2024

@casperiv0 we are planning to do this task together with #2903 and release it with v3.2. If you can take a look before, even better. Maybe we can ship it with v3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📅 Planned
Development

No branches or pull requests

7 participants