Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setBranding does not change the top left logo display in AdminUI #2225

Closed
cdev-enter opened this issue Jun 13, 2023 · 1 comment
Closed

setBranding does not change the top left logo display in AdminUI #2225

cdev-enter opened this issue Jun 13, 2023 · 1 comment
Assignees
@michaelbromley
Labels
type: bug 🐛 Something isn't working

Comments

@cdev-enter
Copy link

Describe the bug
Custom Logo is not used when specifying the small logo path with setBranding().

It copies the file in the to admin/dist/assets/logo-75px.png but the angular component (https://github.com/vendure-ecommerce/vendure/blob/master/packages/admin-ui/src/lib/core/src/components/app-shell/app-shell.component.html#L4) references "assets/logo.svg"

To Reproduce
Follow the steps according to the documentation:
https://docs.vendure.io/plugins/extending-the-admin-ui/admin-ui-theming-branding/

Expected behavior
The logo should change

Environment (please complete the following information):

  • @vendure/core version: 2.0
@cdev-enter cdev-enter added the type: bug 🐛 Something isn't working label Jun 13, 2023
@habibullahturkmen
Copy link

I'm facing the same issues with Vendure v2.0.2

@michaelbromley michaelbromley moved this to 📋 Backlog in Vendure OS Roadmap Jun 26, 2023
@oidt oidt mentioned this issue Jul 10, 2023
Closed
michaelbromley added a commit that referenced this issue Jul 13, 2023
@michaelbromley
refactor(admin-ui): Use webp images for logos
70ee7b2 
Relates to #2225
michaelbromley added a commit that referenced this issue Jul 13, 2023
@michaelbromley
fix(admin-ui): Fix top left logo when using setBranding
120a0bb 
Relates to #2225
@michaelbromley michaelbromley moved this from 📋 Backlog to 🏗 In progress in Vendure OS Roadmap Jul 13, 2023
@michaelbromley michaelbromley moved this from 🏗 In progress to 🔖 Ready in Vendure OS Roadmap Jul 13, 2023
@michaelbromley michaelbromley moved this from 🔖 Ready to ✅ Done in Vendure OS Roadmap Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbromley michaelbromley

Labels
type: bug 🐛 Something isn't working
Projects
Vendure OS Roadmap
Status: 🚀 Shipped
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelbromley @habibullahturkmen @cdev-enter