Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multifile2 #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Multifile2 #58

wants to merge 2 commits into from

Conversation

jankapunkt
Copy link
Collaborator

@jankapunkt jankapunkt commented Feb 28, 2020

This implements multiple file uploads using a multiple Boolean flag in the schema or field config, as discussed in #3 long time ago.

It allows the operating system's file selector to select multiple files, adds these files to a reactive queue and uploads them one-by-one. Uploaded files get assigned a plus Button (as typically in list based Autoform elements).

  • Make sure you're using spaces for indentation
  • TBD: Make sure all new code is documented in-code-docs
  • Make sure new features, or changes in behavior is documented in README.md
  • Make sure this PR was previously discussed, if not create new issue ticket for your PR
  • Give an expressive description what you have changed/added and why
  • Test regression
  • Test full functionality (add, delete, replace, mix of these three)
  • Test backward compatibility

This was referenced Feb 28, 2020
@dr-dimitru
Copy link
Member

@jankapunkt thank you for your contributions and support over this reps.
Let me know when this one is ready to get merged

@dr-dimitru
Copy link
Member

@jankapunkt let me know if you think it's good to merge as it is. Any plans to push more changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants