Fix config issue with type conversion and deprecation warnings #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LandonTClipp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #895.
This fixes two dumb issues:
r.Config.Packagesis not actually resolved into the real value set in the config because... idk viper is weird? Or maybe my code sucks? Either way, the fix is to key off of ther.Config.ConfiguredPackages()value to determine ifpackagesis actually being used or not.The second issue was with an edge case in the config that tried access an empty map in the package-level config. Again, this code sucks so I'm just writing the fix without any tests because I'm focusing most of my effort on v3 right now.