Refactor: move collide2 out as a library #1041
Conversation
Add a new `libraries` directory in parallel to the `engine` for our various library components, and add the `collide2` code there as the first library component as it is the most independent of the various libraries. NOTE: There is no real code change outside of header includes
BenjamenMeyer
requested review from
royfalk,
evertvorster,
stephengtuggy and
kheckwrecker
| # collide2 headers | ||
| ${CMAKE_CURRENT_SOURCE_DIR} | ||
| # VS engine headers | ||
| #${CMAKE_SOURCE_DIR}/engine |
There was a problem hiding this comment.
Please open an issue for refactoring VS out of collide library. It's no good separating it out if it refers to VS all over.
There was a problem hiding this comment.
- collide2 is generally under a difference license (public domain from what I can tell... or rather the UNLICENSE) so at a minimum we gain that clarity.
- agreed - there's a few things (gfx/quaternion.h) that seem to have gotten spread out. it'd be nice to make it more independent that way.
Filed #1042
There was a problem hiding this comment.
Looking at the build failures (#1041 (comment)) I'll have to address some of this somehow... but my goal is to be minimal right now. Not sure if I'll fix up #1041 immediately or just move some checks around in CMake for the moment so Mac/Win builds succeed - more likely just move stuff around b/c it'll probably make more sense long term with other libraries being split out any way.
|
|
||
| #Find Math | ||
| INCLUDE(CheckSymbolExists) | ||
| IF(NOT POW_FUNCTION_EXISTS AND NOT NEED_LINKING_AGAINST_LIBM) |
There was a problem hiding this comment.
I was unable to find a lot of information about this. Is there really a chance modern systems don't have POW? (whatever that is)
I'm asking because a lot of stuff in our cmake was really legacy from 2001.
There was a problem hiding this comment.
I doubt it. Created #1043 to follow up on that.
|
NOTE: I reviewed the build failures:
Both of these were while building the the collide2 library. Interestingly, Linux has no issue with either of these. Probably means that some of the library searches we do in the VS engine need to be more universal for now - at least until #1041 can be completed. |
Add a new
librariesdirectory in parallel to theenginefor our various library components, and add thecollide2code there as the first library component as it is the most independent of the various libraries.NOTE: There is no real code change outside of header includes
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues:
Purpose: