New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support engine change to Radar component #156

Merged

stephengtuggy merged 1 commit into master from task_radar

Feb 13, 2025

Contributor

royfalk commented Feb 7, 2025

Support for vegastrike/Vega-Strike-Engine-Source#804

Fix too large radar range.
Damage Llama.begin, both for testing and for gameplay in general. We now support damaged components in an elegant way and there's no reason a refurbished, second-hand Llama wouldn't have a lot of dings to fix.

Code Changes:

Have the PR Validation Tests been run?

Issues:

Radar range for three units was too large 3x10^9 instead of 10^8. This somehow caused Resource to crash. Not sure why. Double definitely supports more than this number. In any case, this is definitely a type, as all other units are 3x10^8, so fixed it and moved on.


          Support engine change to Radar component

99a9463

Fix too large radar range.
Damage Llama.begin, both for testing and for gameplay in general.

royfalk requested review from BenjamenMeyer, evertvorster and stephengtuggy

February 7, 2025 08:06

royfalk self-assigned this

stephengtuggy approved these changes

View reviewed changes

Contributor

stephengtuggy left a comment

Looks good to me.

BenjamenMeyer approved these changes

View reviewed changes

stephengtuggy merged commit aff5046 into master

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet