PDF support #97
Merged
PDF support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SCII approximations
jonmmease
commented
Sep 9, 2023
| @@ -274,7 +274,7 @@ mod test_vl2png { | |||
| let output_png = dssim::load_image(&Dssim::new(), &output).unwrap(); | |||
|
|
|||
| let attr = Dssim::new(); | |||
| let (diff, _) = attr.compare(&expected_png, &output_png); | |||
| let (diff, _) = attr.compare(&expected_png, output_png); | |||
There was a problem hiding this comment.
clippy --fix caught this
Closed
|
Very cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
Overview
This PR adds dependency-free PDF export support to VlConvert. It's been a journey to get to this point, but I'm really happy with the end result.
How it work
This PR uses VlConvert's SVG export path and then converts the resulting SVG image to a PDF. The bulk of the work is done by the wonderful svg2pdf crate. svg2pdf relies on usvg to convert the original SVG image to a simplified collection of paths, and then converts these paths to PDF.
Text
It's possible to render text using svg2pdf by using usvg to convert text to paths before the SVG tree is passed to svg2pdf. But this approach is suboptimal as the resulting text cannot be selected or searched in a PDF viewer like Adobe Acrobat. I opened an svg2pdf issue in January to talk about embedding text. The typst team (who developed svg2pdf, and the pdf-writer crate it depends on) have been really helpful through this process.
It turned out to be possible to accomplish text embedding on top of svg2pdf without changes to the core library. This PR uses pdf-writer to construct a new PDF document and then uses svg2pdf to convert everything in an SVG file except text to a PDF XObject. Then it traverses the SVG tree again and overlays PDF text on top of the XObject.
The logic for using pdf-writer to embed fonts in the resulting PDF file was taken from the typst project repository. It would be nice to eventually find a way to avoid duplicating this logic, but the duplication is worth it for the time being.
Testing
This logic is tested from Python using pdfium2 to convert the PDF to a PNG image and comparing to our existing PNG baselines. The comparison tolerance needs to be a little larger due to the slight differences in text rendering between pdfium and resvg, but they still match really well!
TODO