Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resvg and svg2pdf, support matching font faces by post script name #170

Merged
merged 23 commits into from
Jun 19, 2024
Merged

Update resvg and svg2pdf, support matching font faces by post script name #170

merged 23 commits into from
Jun 19, 2024

Conversation

jonmmease
Copy link
Collaborator

@jonmmease jonmmease commented Jun 19, 2024 •
edited
Loading

This PR accomplishes several things.

  1. Updates svg2pdf and resvg to the latest versions
  2. Adds a custom usvg "font selector" that understands how to deal with font families that include weight/style info. Like "Matter SemiBold" from Experiencing issues with register_font_directory and semibold font files #167.
  3. Adds a custom usvg "fallback selector" that knows to skip the "LastResort" font on macOS. This was preventing the selection of the "Apple Color Emoji" font for rendering emoji. This update to resvg now includes support for rendering color emoji to PNG 🎉
  4. Updates PDF export to use the latest svg2pdf, which performs font embedding. I deleted our vl-convert-pdf workaround, which layered embedded text on top of the PDF produced by svg2pdf.

This will close #167, #137, and #147

jonmmease added 23 commits June 19, 2024 05:55
@jonmmease jonmmease merged commit a54d526 into main Jun 19, 2024
10 checks passed
@jonmmease jonmmease deleted the jonmmease/update-resvg-svg2pdf branch June 19, 2024 19:51
@jonmmease jonmmease mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiencing issues with register_font_directory and semibold font files
1 participant
@jonmmease