Support loading images from urls without extensions #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
commented
Apr 14, 2024
| ``` | ||
| RUST_LOG=vl_convert | ||
| RUST_LOG=info | ||
| ``` |
There was a problem hiding this comment.
This way logging info for usvg is displayed as well
jonmmease
commented
Apr 14, 2024
There was a problem hiding this comment.
update to cargo-bundle-license crate
jonmmease
commented
Apr 14, 2024
| return None; | ||
| }; | ||
| get_text_width_from_path(node) | ||
| get_text_width_from_path(text.convert(font_db, Default::default())?) |
jonmmease
commented
Apr 14, 2024
| @@ -29,21 +29,18 @@ pub type ImageHrefStringResolverFn = Box<dyn Fn(&str, &Options) -> Option<ImageK | |||
| pub fn custom_string_resolver() -> ImageHrefStringResolverFn { | |||
| let default_string_resolver = ImageHrefResolver::default_string_resolver(); | |||
| Box::new(move |href: &str, opts: &Options| { | |||
| info!("Resolving image: {href}"); | |||
|
Very clever solution! Really cool to read your code🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
The issue was that this tile provider serves images in jpg format, but the URLs do not include a file extension (e.g. https://server.arcgisonline.com/ArcGIS/rest/services/Canvas/World_Light_Gray_Base/MapServer/tile/5/14/17) and usvg uses the file extension to infer the image type. This PR adds logic to infer the image type from the
Content-Typeheader and use that to build a file extension that usvg is happy with.cc @binste