Handle special characters in projection pushdown #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was: Projections require unique expression names but the expression \"tbl_1.pe.riods\" at position 1 and \"tbl_1.pe.riods\" at position 2 have the same name
|
Waiting on clippy formatting updates from #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a previously failing test in e7e8d2a. The issue is that projection pushdown was creating a transform that looked like this:
{ "type": "project", "fields": ["pe.riod", "pe\\.riod"] }The resulting error was:
To fix the issue, 81f5aef updates the
transform_columnstransform spec implementations to unescape fields before including them inColumnUsagesets.4794951 updates the (un)escape logic to handle periods and brackets.