Add forward compatibility with Altair 5 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binste
reviewed
Jan 22, 2023
Comment on lines
+39
to
+44
| try: | ||
| # Altair 5 | ||
| from altair.vegalite.v5 import SCHEMA_VERSION | ||
| except ImportError: | ||
| # Altair 4 | ||
| from altair.vegalite.v4 import SCHEMA_VERSION |
There was a problem hiding this comment.
@jonmmease You can get the current schema version by importing it from top-level altair directly:
from altair import SCHEMA_VERSIONThis way, it's compatible with future versions of Altair without having to modify this part of the code.
binste
reviewed
Jan 22, 2023
Comment on lines
+6
to
+11
| try: | ||
| # Altair 5 imports | ||
| from altair.vegalite.v5.api import Chart, FacetChart | ||
| except ImportError: | ||
| # Altair 4 imports | ||
| from altair.vegalite.v4.api import Chart, FacetChart |
There was a problem hiding this comment.
@jonmmease Same here as described in the other comment:
from altair import Chart, FacetChart
|
Thanks for the comments @binste, that is much easier 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds forward compatibility with Altair 5 (which is not yet released)