Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to DataFusion 10 #148

Merged
merged 11 commits into from
Jul 29, 2022
Merged

Update to DataFusion 10 #148

merged 11 commits into from
Jul 29, 2022

Conversation

jonmmease
Copy link
Collaborator

@jonmmease jonmmease commented Jul 28, 2022

Second attempt to update to DataFusion 10

To resolve a circular dependency associated with wasm-bindgen and indexmap, I needed to remove the serde-serialize feature of wasm-bindgen. The circular dependency was similar to that reported in https://stackoverflow.com/questions/68399961/how-do-i-resolve-a-cyclic-dependency-in-cargo.

@jonmmease jonmmease marked this pull request as draft July 28, 2022 22:22
@jonmmease jonmmease changed the title Another attempt to update to DataFusion Update to DataFusion 10 Jul 29, 2022
@jonmmease jonmmease marked this pull request as ready for review July 29, 2022 12:21
@jonmmease
Copy link
Collaborator Author

Something broke our implementation of the stack transform with DataFusion PR apache/datafusion#2819. Going to update this PR to use the prior DataFusion commit: 57f47ab9230a9a12b3244191dcf1623f8b69fd61 (which is on this PR apache/datafusion#2809).

@jonmmease
Copy link
Collaborator Author

Stack transform issue is remediated by 51ea5f1

@jonmmease jonmmease merged commit 9426f9c into main Jul 29, 2022
@jonmmease jonmmease deleted the datafusion_10b branch July 29, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant