Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configurable output timezone in pre_transform_spec #116

Merged
merged 37 commits into from
May 28, 2022
Merged

Support configurable output timezone in pre_transform_spec #116

merged 37 commits into from
May 28, 2022

Commits on May 26, 2022

  1. Add override timezone argument to timeFormat and toDate expression fu… 

    …nctions
    @jonmmease
    jonmmease committed May 26, 2022
    Configuration menu
    Copy the full SHA
    0f6381f View commit details
    Browse the repository at this point in the history

  2. Add initial support to pre_transform_spec to store local datetimes in… 

    … custom format timezone
    @jonmmease
    jonmmease committed May 26, 2022
    Configuration menu
    Copy the full SHA
    3c40643 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Add extract_inline_data planner config option 

    When true, datasets with inline values are extracted onto the server spec.
When false, these datasets are left in the client spec.

When performing pre_transform_spec on the server, it's preferable to set this
to true. But if planning is done on the client, then the past default of false
is more appropriate.
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    6912ad7 View commit details
    Browse the repository at this point in the history

  2. Handle inline data values as array of scalars

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    1c3012f View commit details
    Browse the repository at this point in the history

  3. Add date parsing for "Sun, 01 Jan 2012 00:00:00" 

    This format is found throughout the vega-lite examples
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    2e99c67 View commit details
    Browse the repository at this point in the history

  4. Fix invalid date strings

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    8f5a4af View commit details
    Browse the repository at this point in the history

  5. Remove mistyped values from likert example 

    Vega skips over the bad values since each row can have a different type.
When arrow reads this the values column is inferred as String type,
and all of the numeric values are read as null.
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    735e5de View commit details
    Browse the repository at this point in the history

  6. Fix bogus date strings in mocks

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    1bb0e1b View commit details
    Browse the repository at this point in the history

  7. Update test predicate. 

    Explanation: The way arrow parses this is for the datum.options.price to be null,
but not datum.options.
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    e628130 View commit details
    Browse the repository at this point in the history

  8. Special case json data

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    eae2f66 View commit details
    Browse the repository at this point in the history

  9. Restrict the forms of values supported on the server

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    6564b04 View commit details
    Browse the repository at this point in the history

  10. Add additional date formats to cover vega-lite examples

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    d638f3b View commit details
    Browse the repository at this point in the history

  11. Fix test_planning

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    796414a View commit details
    Browse the repository at this point in the history

  12. Break rank tie so test doesn't rely on undefined order of tie rank

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    792746f View commit details
    Browse the repository at this point in the history

  13. Remove extra data reference. 

    Vega fails when this is present in the pre-transformed version
of the spec.
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    94b2fbf View commit details
    Browse the repository at this point in the history

  14. Fix pre-transform tests now that inline values can be moved to the se… 

    …rver
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    25cf2c4 View commit details
    Browse the repository at this point in the history

  15. Expose format_tz through Python

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    db4b835 View commit details
    Browse the repository at this point in the history

  16. clippy fix

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    095e82e View commit details
    Browse the repository at this point in the history

  17. Add pre-transform stringify datetimes test

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    9d40ef4 View commit details
    Browse the repository at this point in the history

  18. fix warnings

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    97d4f0b View commit details
    Browse the repository at this point in the history

  19. Update datafusion hash to include fix for 

    apache/datafusion#2463
    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    8692c7a View commit details
    Browse the repository at this point in the history

  20. Rename to output_tz and OutputLocalDatetimesConfig

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    ce01028 View commit details
    Browse the repository at this point in the history

  21. cargo format

    @jonmmease
    jonmmease committed May 27, 2022
    Configuration menu
    Copy the full SHA
    4406c38 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. Don't compile vegafusion-python-embed and vegafusion-wasm crates duri… 

    …ng testing
    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    9803a7e View commit details
    Browse the repository at this point in the history

  2. try downgrading toolchain

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    251f43c View commit details
    Browse the repository at this point in the history

  3. full version string

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    399e728 View commit details
    Browse the repository at this point in the history

  4. re-enable CI tests

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    bd86463 View commit details
    Browse the repository at this point in the history

  5. Try remove rust cache

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    8c1244b View commit details
    Browse the repository at this point in the history

  6. Try update to windows 2022

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    2e7a91b View commit details
    Browse the repository at this point in the history

  7. Try install protoc with choco

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f001281 View commit details
    Browse the repository at this point in the history

  8. query disk space

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    3454a20 View commit details
    Browse the repository at this point in the history

  9. Try moving CARGO_HOME to C: drive on windows

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    91d0658 View commit details
    Browse the repository at this point in the history

  10. only on windows

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    763ed05 View commit details
    Browse the repository at this point in the history

  11. Try setting CARGO_TARGET_DIR to C:\ drive

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    a7b849d View commit details
    Browse the repository at this point in the history

  12. Uncomment other operating systems

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    120f57c View commit details
    Browse the repository at this point in the history

  13. Enable remaining tests

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    00f089e View commit details
    Browse the repository at this point in the history

  14. Add protoc installs for windows jobs

    @jonmmease
    jonmmease committed May 28, 2022
    Configuration menu
    Copy the full SHA
    f1e808a View commit details
    Browse the repository at this point in the history