Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only append tooltip element to container once #626

Merged
merged 1 commit into from
Jan 28, 2022
Merged

fix: only append tooltip element to container once #626

merged 1 commit into from
Jan 28, 2022

Conversation

svdm
Copy link
Contributor

@svdm svdm commented Jan 28, 2022 •
edited by github-actions bot
Loading

Fixes #625

Version

Published prerelease version: v0.28.0-next.1

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, Stefan van der Meer (@svdm), for all your work!

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to next

  • ci: use same release script as in other vega repos (@domoritz)
  • chore: upgrade deps (@domoritz)

🔩 Dependency Updates

Authors: 3

@svdm
fix: only append tooltip element to container once
afd0991 
The tooltip element was being appended to its container on every
mousemove. Updating the DOM in this way is relatively slow on complex
pages, so this was causing the tooltip to "lag" behind the cursor.
@domoritz domoritz merged commit 7e2b7c0 into vega:next Jan 28, 2022
@domoritz
Copy link
Member

Thank you!

@jovancacvetkovic jovancacvetkovic mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip is slow due to excessive DOM modification
2 participants
@svdm @domoritz