fix: mark position calculation when only x or y are defined (#974)

vega · Nov 16, 2024 · 795bd70 · 795bd70
1 parent ae1ec95
commit 795bd70
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/position.ts b/src/position.ts
@@ -96,10 +96,8 @@ export function getMarkBounds(
   let parentItem = item;
   while (parentItem.mark.group) {
     parentItem = parentItem.mark.group;
-    if ('x' in parentItem && 'y' in parentItem) {
-      left += parentItem.x;
-      top += parentItem.y;
-    }
+    left += parentItem.x ?? 0;
+    top += parentItem.y ?? 0;
   }
 
   const markWidth = markBounds.x2 - markBounds.x1;

diff --git a/test/position.test.ts b/test/position.test.ts
@@ -107,6 +107,10 @@ describe('getMarkBounds()', () => {
     expect(getMarkBounds({left: 0, top: 0}, [0, 0], defaultItem)).toEqual({x1: 150, x2: 200, y1: 75, y2: 125});
     expect(getMarkBounds({left: 0, top: 0}, [0, 0], item)).toEqual({x1: 190, x2: 240, y1: 135, y2: 185});
   });
+  test('should sum the offsets even if only x is defined', () => {
+    const item = {...defaultItem, mark: {group: {x: 10, mark: {group: {x: 30, mark: {}}}}}};
+    expect(getMarkBounds({left: 0, top: 0}, [0, 0], item)).toEqual({x1: 190, x2: 240, y1: 75, y2: 125});
+  });
 });
 
 describe('getPositions()', () => {