refactor: small code simplificiations #9208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsh
reviewed
Jan 21, 2024
| @@ -76,7 +76,7 @@ const scaleBindings: SelectionCompiler<'interval'> = { | |||
| // Nested signals need only push to top-level signals with multiview displays. | |||
| if (model.parent && !isTopLevelLayer(model)) { | |||
| for (const proj of selCmpt.scales) { | |||
| const signal: any = signals.filter(s => s.name === proj.signals.data)[0]; | |||
| const signal: any = signals.find(s => s.name === proj.signals.data); | |||
There was a problem hiding this comment.
Find returns undefined if there is no such item. The previous code would crash so I think the new one is strictly better, no?
There was a problem hiding this comment.
Isn't the following line signal.push = ...? If find returns undefined what would we do? Otherwise why will it always be defined?
There was a problem hiding this comment.
Not sure but the previous behavior was to get an element from an empty array which also returns undefined so this should be an equivalent change.
There was a problem hiding this comment.
Fair enough. I was just hoping we'd be able to also add some sort of comment to increase confidence in local reasoning.
lsh
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.