Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update valid image path #9196

Closed
wants to merge 1 commit into from

Conversation

ChiaLingWeng
Copy link
Contributor

this is a follow up to #9171 and will close #9151.
since the original pull request is a little messy and the workflow failed thus open a new one here,
for this issue, the most graceful solution I think is to add a symbolic link that points to the valid data folder.

image

@domoritz
Copy link
Member

Hmm, https://vega.github.io/vega-lite/docs/image.html#examples works but https://vega.github.io/vega-lite/docs/tooltip.html#tooltip-image does not because the base url doesn't seem to be set correctly for the tooltip.

@domoritz
Copy link
Member

I think the real issue here is that the tooltip plugin doesn't use the baseurl from the loader.

@domoritz
Copy link
Member

I think the best fix is to pass the baseurl through to tooltips. Done in vega/vega-embed#1286

@domoritz domoritz closed this Dec 14, 2023
@ChiaLingWeng
Copy link
Contributor Author

Good to know where is the issue from, thanks!

@domoritz
Copy link
Member

Thank you for filing the bug and looking into fixing it. Seeing your fixes helped me pinpoint the bug much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tooltip images in docs
2 participants