Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move name from layer chart to one of the inside layers #8662

Merged
merged 4 commits into from
Feb 13, 2023
Merged

fix: move name from layer chart to one of the inside layers #8662

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8a4b5d
Move name from layer chart to one of the inside layers
ChristopherDavisUCI Jan 21, 2023
431d32b
chore: update TOC [CI]
Jan 21, 2023
f787134
Merge branch 'main' into cd/name-in-layer
domoritz Feb 13, 2023
fb40b94
chore: update TOC [CI]
Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/normalize/pathoverlay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit

public run(spec: UnitSpecWithPathOverlay, normParams: NormalizerParams, normalize: NormalizeLayerOrUnit) {
const {config} = normParams;
const {params, projection, mark, encoding: e, ...outerSpec} = spec;
const {params, projection, mark, name, encoding: e, ...outerSpec} = spec;

// Need to call normalizeEncoding because we need the inferred types to correctly determine stack
const encoding = normalizeEncoding(e, config);
Expand All @@ -113,6 +113,7 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit

const layer: NormalizedUnitSpec[] = [
{
name,
...(params ? {params} : {}),
mark: dropLineAndPoint({
// TODO: extract this 0.7 to be shared with default opacity for point/tick/...
Expand Down