Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add normalizedNumberFormat for stack: "normalize" tooltips #8307

Merged
merged 23 commits into from
Jul 22, 2022
Merged

feat: add normalizedNumberFormat for stack: "normalize" tooltips #8307

merged 23 commits into from
Jul 22, 2022

Conversation

lsh
Copy link
Member

@lsh lsh commented Jul 22, 2022 •
edited by vega-org-bot
Loading

This PR succeeds #8303, since the CI was getting a little messy for that one. As such, this PR addresses #8300.

📦 Published PR as canary version: 5.3.1--canary.8307.d0afe80.0

✨ Test out this PR locally via:

npm install vega-lite@5.3.1--canary.8307.d0afe80.0
# or 
yarn add vega-lite@5.3.1--canary.8307.d0afe80.0

Version

Published prerelease version: v5.3.1-next.3

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, Lukas Hermann (@lsh), for all your work!

🐛 Bug Fix

Authors: 6

@lsh lsh mentioned this pull request Jul 22, 2022
Closed
@lsh lsh requested review from kanitw and domoritz and removed request for kanitw July 22, 2022 18:55
kanitw
kanitw reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it doesn't apply correctly to axis yet?

image

@lsh
Copy link
Member Author

lsh commented Jul 22, 2022

@kanitw in that case we don't have a customFormatType or normalizedNumberFormatType defined, right?

@lsh lsh requested a review from kanitw July 22, 2022 20:07
kanitw
kanitw reviewed Jul 22, 2022
View reviewed changes
src/compile/axis/encode.ts Show resolved Hide resolved
src/compile/format.ts Outdated Show resolved Hide resolved
examples/compiled/stacked_bar_normalize.vg.json Outdated Show resolved Hide resolved
kanitw
kanitw reviewed Jul 22, 2022
View reviewed changes
src/compile/format.ts Outdated Show resolved Hide resolved
kanitw
kanitw reviewed Jul 22, 2022
View reviewed changes
test/compile/format.test.ts Outdated Show resolved Hide resolved
@kanitw kanitw changed the title Feat: add normalizedNumberFormat for stack: "normalize" tooltips feat: add normalizedNumberFormat for stack: "normalize" tooltips Jul 22, 2022
@kanitw kanitw merged commit 19deddc into next Jul 22, 2022
@kanitw kanitw deleted the lsh/normalized-number-format branch July 22, 2022 23:54
@vega-org-bot
Copy link
Collaborator

🚀 PR was released in v5.3.1-next.3 🚀

@lsh lsh mentioned this pull request Jul 23, 2022
Closed
@vega-org-bot vega-org-bot mentioned this pull request Jul 25, 2022
Merged
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@kanitw @BradyJ27
feat: add normalizedNumberFormat for stack: "normalize" tooltips (v…
55ebb64 
…ega#8307)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Co-authored-by: Kanit Wongsuphasawat <kanitw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanitw kanitw kanitw approved these changes

@domoritz domoritz Awaiting requested review from domoritz

Assignees
No one assigned
Labels
prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsh @vega-org-bot @kanitw