feat!: make view width / height support {step: number}
#5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/step
branch
3 times, most recently
from
494fcfe
to
0215145
Compare
kanitw
changed the title
width / height support {step: number} + remove scale.rangeStepwidth / height support {step: number} + remove scale.rangeStep
kanitw
changed the title
width / height support {step: number} + remove scale.rangeStepwidth / height support {step: number}
BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
kanitw
force-pushed
the
kw/step
branch
2 times, most recently
from
71df39a
to
19bcf18
Compare
kanitw
force-pushed
the
kw/step
branch
3 times, most recently
from
dae260f
to
ebb4b1e
Compare
domoritz
pushed a commit
that referenced
this pull request
Jul 5, 2019
* feat!: Make view `width` / `height` support `{step: number}`
BREAKING CHANGE: `scale.rangeStep` deprecated
BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
* docs: improve size.md
* test: unit tests for layoutsize
* [Travis] Update schema (build: 24151)
* [Travis] Update examples (build: 24151)
kanitw
added a commit
that referenced
this pull request
Jul 20, 2019
* feat!: Make view `width` / `height` support `{step: number}`
BREAKING CHANGE: `scale.rangeStep` deprecated
BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
* docs: improve size.md
* test: unit tests for layoutsize
* [Travis] Update schema (build: 24151)
* [Travis] Update examples (build: 24151)
domoritz
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat!: Make view `width` / `height` support `{step: number}`
BREAKING CHANGE: `scale.rangeStep` deprecated
BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
* docs: improve size.md
* test: unit tests for layoutsize
* [Travis] Update schema (build: 24151)
* [Travis] Update examples (build: 24151)
domoritz
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat!: Make view `width` / `height` support `{step: number}`
BREAKING CHANGE: `scale.rangeStep` deprecated
BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
* docs: improve size.md
* test: unit tests for layoutsize
* [Travis] Update schema (build: 24151)
* [Travis] Update examples (build: 24151)
willium
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat!: Make view `width` / `height` support `{step: number}`
BREAKING CHANGE: `scale.rangeStep` deprecated
BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
* docs: improve size.md
* test: unit tests for layoutsize
* [Travis] Update schema (build: 24151)
* [Travis] Update examples (build: 24151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added
config.view.continuousWidth/Heightandconfig.view.discreteWidth/HeightBREAKING CHANGE: Remove
scale.rangeStepBREAKING CHANGE: Rename
config.scale.rangeSteptoconfig.view.stepFix #5083 (only missing backward compatibility)
Note:
The followup in refactor: simplify scale range parameters and tests #5145 provides a bit better test coverage.
I'll add normalize for backward compatibility in a separate PR ( fix: add rangeStep normalizer to provide backward compatibility #5148), so we can revert easily.