-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: make view width
/ height
support {step: number}
#5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/step
branch
3 times, most recently
from
June 29, 2019 23:56
494fcfe
to
0215145
Compare
kanitw
changed the title
feat!: Make view
feat!: make view Jun 29, 2019
width
/ height
support {step: number}
+ remove scale.rangeStep
width
/ height
support {step: number}
+ remove scale.rangeStep
kanitw
changed the title
feat!: make view
feat!: make view Jun 29, 2019
width
/ height
support {step: number}
+ remove scale.rangeStep
width
/ height
support {step: number}
BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step`
kanitw
force-pushed
the
kw/step
branch
2 times, most recently
from
June 30, 2019 06:10
71df39a
to
19bcf18
Compare
kanitw
force-pushed
the
kw/step
branch
3 times, most recently
from
June 30, 2019 06:24
dae260f
to
ebb4b1e
Compare
domoritz
pushed a commit
that referenced
this pull request
Jul 5, 2019
* feat!: Make view `width` / `height` support `{step: number}` BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step` * docs: improve size.md * test: unit tests for layoutsize * [Travis] Update schema (build: 24151) * [Travis] Update examples (build: 24151)
kanitw
added a commit
that referenced
this pull request
Jul 20, 2019
* feat!: Make view `width` / `height` support `{step: number}` BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step` * docs: improve size.md * test: unit tests for layoutsize * [Travis] Update schema (build: 24151) * [Travis] Update examples (build: 24151)
domoritz
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat!: Make view `width` / `height` support `{step: number}` BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step` * docs: improve size.md * test: unit tests for layoutsize * [Travis] Update schema (build: 24151) * [Travis] Update examples (build: 24151)
domoritz
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat!: Make view `width` / `height` support `{step: number}` BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step` * docs: improve size.md * test: unit tests for layoutsize * [Travis] Update schema (build: 24151) * [Travis] Update examples (build: 24151)
willium
pushed a commit
that referenced
this pull request
Jul 25, 2019
* feat!: Make view `width` / `height` support `{step: number}` BREAKING CHANGE: `scale.rangeStep` deprecated BREAKING CHANGE: `config.scale.rangeStep` renamed to add `config.view.step` * docs: improve size.md * test: unit tests for layoutsize * [Travis] Update schema (build: 24151) * [Travis] Update examples (build: 24151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added
config.view.continuousWidth/Height
andconfig.view.discreteWidth/Height
BREAKING CHANGE: Remove
scale.rangeStep
BREAKING CHANGE: Rename
config.scale.rangeStep
toconfig.view.step
Fix #5083 (only missing backward compatibility)
Note:
The followup in refactor: simplify scale range parameters and tests #5145 provides a bit better test coverage.
I'll add normalize for backward compatibility in a separate PR ( fix: add rangeStep normalizer to provide backward compatibility #5148), so we can revert easily.