[WIP] Revise `window` transform + Add Docs / Examples #3199

AkshatSh · 2017-11-15T05:13:26Z

Implemented Window Transform for Vega Lite
Issue #2488

kanitw

This looks like a great start. I have some styling / docs
comments.

@domoritz please feel free to add more comments if you have time. (I'm pretty swamped too so only got a chance to quickly look at this.)

kanitw · 2017-11-15T06:25:20Z

src/compile/data/window.ts

+
+export class WindowTransformNode extends DataFlowNode {
+  public clone(): WindowTransformNode {
+      return new WindowTransformNode(duplicate(this.transform));


kanitw · 2017-11-15T06:26:29Z

src/compile/data/window.ts

+    const result: VgWindowTransform = {
+      type: 'window',
+      params: params,
+      as: as,


kanitw · 2017-11-15T06:26:56Z

src/compile/data/window.ts

+
+    const result: VgWindowTransform = {
+      type: 'window',
+      params: params,


just do

params, as, ops, // rename operations to ops fields

kanitw · 2017-11-15T06:27:46Z

src/transform.ts

@@ -97,6 +98,57 @@ export interface AggregatedFieldDef {
  as: string;
 }

+export interface WindowFieldDef {
+  /**
+   * The operations supported for the window aggregation


Need to link to the table that lists all supported operations in the docs.

kanitw · 2017-11-15T06:28:13Z

src/transform.ts

+  op: AggregateOp | WindowOnlyOp;
+
+  /**
+   * The optional parameters for the operation


Add full stop.

Explain a bit more that look at the operator table to see parameter for each operation.

kanitw · 2017-11-15T06:28:39Z

src/transform.ts

+  field?: string;
+
+  /**
+   * The name for the new field in the window transform


full stop.. can you add it all for the rest of the docs.

kanitw · 2017-11-15T06:28:50Z

src/transform.ts

+  window: WindowFieldDef[];
+
+  /**
+   * The frame for the window, if none is set the default is [null, 0] everything before the


use back tick around code

kanitw · 2017-11-15T06:29:20Z

src/transform.ts

+  frame?: Number[];
+
+  /**
+   * Whether to ignoreThePeers during the comparison in the window


Why camelcase for ignoreThePeers?

kanitw · 2017-11-15T06:30:48Z

src/transform.ts

@@ -139,10 +191,26 @@ export interface LookupTransform {
  default?: string;
 }

+export interface Comparator {


Wonder if naming this SortField or WindowSortField make more sense?
(But not sure if there is another thing already called SortField -- but this is definitely slightly different from sort 's SortField(Def?).

I made a couple changes and this should be reflective of the Comparator defined here now: https://vega.github.io/vega/docs/types/#Compare

Um, I haven't looked how you do it -- but seeing that you mention that you make it like "Compare" in Vega. I would like to mention that it might be more important to make it more consistent with rest of Vega-Lite language than the underlying Vega.

kanitw · 2017-11-15T06:32:11Z

src/compile/data/window.ts

+import {WindowOnlyOp} from '../../window';
+import {AggregateOp} from '../../aggregate';
+
+export class WindowTransformNode extends DataFlowNode {


WindowNode?

kanitw · 2017-11-15T06:34:12Z

src/vega.schema.ts

+
+export interface VgComparator {
+  field?: string | string[];
+  order?: VgComparatorOrder;


shouldn't this allow array too?

Assuming this is referring to the field parameter, it is resolved.

kanitw · 2017-11-16T00:23:53Z

src/compile/data/window.ts

+      sort: this.transform.sort
+    };
+
+    return result;


minor -- but I guess you can just return the line above

kanitw · 2018-01-21T23:56:36Z

@domoritz – Can you help @AkshatSh figure why the Travis says that new specs in this PR do not pass validation? I tried testing in the local machine myself, but it's passing ok for me.

kanitw · 2018-01-23T22:46:36Z

examples/examples.test.ts

@@ -33,7 +33,7 @@ function validateVL(spec: TopLevelExtendedSpec) {
 }

 function validateVega(spec: TopLevelExtendedSpec) {
-  const vegaSpec = compile(spec).spec;
+  const vegaSpec = JSON.parse(JSON.stringify(compile(spec).spec));


@domoritz -- any idea why this makes some validation passes?

@AkshatSh -- this commit should be separated from other changes as it's a controversial change.

This removes undefines and is not something we should do in tests. I am strongly against this change.

Oh I see, what happens when you stringify something that is undefined?

I'll look into the tests more than and try to fix them without using this change.

kanitw

Cool. This is a good progress!

I have just rebased and re-compile an example so hopefully the test will pass now.

I think we're in the last mile for this PR.

Please address my comments and add a doc page for window. I think once you try to write a documentation. You might want to modify your examples so you can embed them to show diversity in your PR.

kanitw · 2018-02-10T20:50:31Z

src/transform.ts

+  frame?: (null | number)[];
+
+  /**
+   * Whether to ignoreThePeers during the comparison in the window.


The description here reads quite confusing. I don't understand what is "Whether to ignoreThePeers during the comparison in the window."

For each of the window transform property, please copy the more detailed description from Vega docs and edit them so they are sensible with Vega-Lite.

kanitw · 2018-02-10T20:51:55Z

src/transform.ts

+  /**
+   * The comparator to use to determine the window.
+   */
+  sort?: Comparator;


Why not just ComparatorField[]?

The nested "compare" seems unnecessary.

{ ... sort: { compare: [...] } }

kanitw · 2018-02-10T20:52:11Z

src/transform.ts

+  order?: ('ascending' | 'descending');
+}
+
+export interface Comparator {


kanitw · 2018-02-10T20:52:21Z

src/transform.ts

+/**
+ * A comparator fields
+ */
+export interface ComparatorField {


WindowSortField?

kanitw · 2018-02-10T20:53:24Z

src/transform.ts

+  op: AggregateOp | WindowOnlyOp;
+
+  /**
+   * The optional parameters for the operation. For example the window operator (nth_value)


For example, (missing ,)

Also point to the window operation table for specific parameter for each operation?

kanitw · 2018-02-10T20:59:00Z

src/transform.ts

+export interface WindowFieldDef {
+  /**
+   * The operations supported for the window aggregation. See the list of supported operations here:
+   *   https://vega.github.io/vega/docs/transforms/window/#ops


Please do not link to Vega docs.

Instead write a Vega-Lite docs for window (and you can copy the listed operations to this new page.)

kanitw · 2018-02-10T21:01:33Z

examples/specs/window_transform.vl.json

+    "height": 50,
+    "data": {
+        "values": [
+            { "x": 1, "y": 28 }, { "x": 2, "y": 55 },


Why do the data need "x" here at all?

Also, maybe rename this file to window_row_number?

kanitw · 2018-02-10T21:06:06Z

examples/specs/window_transform_average_rating.vl.json

@@ -0,0 +1,44 @@
+{
+    "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
+    "description": "Bar graph showing how each film differs from the average rating for that year",


I think this example is quite confusing.
I took me a while to get that "Good" "Bad" "Average" are movie names. Maybe better put actual movie names in there?

Also, it's kinda weird that you calculate average ratings for one movie in 2015.

Perhaps, try to re-create examples using the movies data instead? (Feel free to play with it in Voyager a bit.)

I liked this example because it could group by year. I changed the movie names to be Move One etc. I also added another example to use the movies.json file and do something similar there.

I'd add another movie for 2015 to make it less weird. Also, looks like the bar is acting weird here. (Why isn't it starting from zero?) -- Use point for now and file a bug?

[@AkshatSh]: If the bug is that the part start's from -10, it is because I defined the domain to be [-10,10]. This was because I wanted to be able to see how each movie was below and above average for that year.

Btw, this example seems redundant with window_transform_movie_mean_difference.vl.json?

An improved window_transform_movie_mean_difference.vl.json would be way more interesting, so remove this one?

(Still, please file a bug that bar for this one is wrong.)

kanitw · 2018-02-10T21:06:54Z

examples/specs/window_transform_time_spent_in_class.vl.json

@@ -0,0 +1,53 @@
+{
+    "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
+    "description": "Bar graph showing how each film differs from the average rating for that year",


outdated description?

I'm also not sure what this plot try to communicate.

I was trying to make a more complicated window transform example. The purpose was to show how long each student has been in class until the current class. So if student A and B both show up to a class, the graph will show that class along with the total time each student has been at school, to show how tired (or the fatigue) of a student during that class. For example, something like this could be used to see the affects of taking an exam after a lot of other classes vs taking an exam at the beginning of the day or when there are a few classes before hand.

I changed the name of the axis to be Time Spent in Class instead to hopefully make this more clear. I have also updated the description.

kanitw · 2018-02-10T21:08:48Z

examples/specs/window_transform_time_spent_in_class.vl.json

+            "y": {
+                "field": "TimeInClass",
+                "type": "quantitative",
+                "axis": { "title": "Fatigue", "grid": false }


"fatigue" as a title axis is quite confusing to me.

kanitw · 2018-02-10T21:11:03Z

Btw, please make sure to demonstrate these cases in your doc page:

Percent of total
Different from total/mean
Percent difference from total/mean

kanitw · 2018-03-05T00:26:27Z

@AkshatSh

We're hoping to release 2.2 (#3461) some times next quarter.
I wonder if you would have time over spring break to finish this. (No worry about it this week of course, I know it's the dead week.)

kanitw

Thanks! We're getting really close!

I have some comments.
Please squash all existing commits into 3 commits

One for all the code changes. (I might just cherry pick and merge this first so we will unblock @mattwchun to add outliers to boxplot)
One for just the new documentation file.
Another for just examples.

(If this is hard we can also just make all of them one commit too.)

Then please add new commits to address my changes.

For the examples, I think some of the examples still need improvement. You may choose to just remove some of them (e.g., window_transform_time_spent_in_class.vl.json) and focus on adding full examples for common use cases that you currently listed in the documentation.

kanitw · 2018-03-18T06:08:49Z

site/docs/transform/window.md

+
+| Property    | Type | Description  |
+| :----------- | :-------: | :------------|
+| window | WindowFieldDef[] | The definition of the fields in the window, and what calculations to use. |


Use a special tag and make sure that you have the JSDocs in the code include comments for all of these

{% include table.html props="window,frame,ignorePeers,groupBy,sort" source="WindowTransform" %}

(Window Only Operation Reference can't use this table thing though as it's a list of valid values, not property table.)

Oh thats pretty cool. I didn't know about that tag. Just updated it to use that for the 3 object definitions (WindowTransform, WindowSortField, WIndowFieldDef).

kanitw · 2018-03-18T06:10:41Z

site/docs/transform/window.md

+
+### Percent of Total
+
+```json


Can you add actual Vega-Lite specs for all of these? Also make sure to include other good examples that you're adding.

<div class="vl-example" data-name="example-file-name-without-extension"></div>

kanitw · 2018-03-18T06:11:28Z

src/compile/data/window.ts

+      ops,
+      fields,
+      sort,
+    };


Weird... What's the error?

kanitw · 2018-03-18T06:12:07Z

src/transform.ts

+ */
+export interface WindowSortField {
+  field: string;
+  order?: ('ascending' | 'descending');


No need for parentheses?

kanitw · 2018-03-18T06:13:01Z

src/transform.ts

+  op: AggregateOp | WindowOnlyOp;
+
+  /**
+   *  Parameter values for the window functions. Parameter value can be null for operations that do not accept a


"See the list of operations for each operation's supported parameter."?

Also, for operations that do not accept a parameter -- should param really be null? Why not undefined (omitted)?

That was my mistake. I copied the definition from the vega docs, but here it can just be omitted. Updated to remove that.

kanitw · 2018-03-18T06:27:47Z

examples/specs/window_transform_average_rating.vl.json

@@ -0,0 +1,44 @@
+{
+    "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
+    "description": "Bar graph showing how each film differs from the average rating for that year",


I'd add another movie for 2015 to make it less weird. Also, looks like the bar is acting weird here. (Why isn't it starting from zero?) -- Use point for now and file a bug?

[@AkshatSh]: If the bug is that the part start's from -10, it is because I defined the domain to be [-10,10]. This was because I wanted to be able to see how each movie was below and above average for that year.

kanitw · 2018-03-18T06:28:43Z

examples/specs/window_transform_row_number.vl.json

+    "layer": [{
+        "transform": [{
+                "calculate": "datum.y - 50",
+                "as": "ny"


What is this ny for?

kanitw · 2018-03-18T06:29:22Z

examples/specs/window_transform_row_number.vl.json

@@ -0,0 +1,46 @@
+{


Why is this example important?
(Is it important for explaining any concept in the documentation?)

I'd say rank chart as in https://stats.stackexchange.com/a/178344 is a more compelling use case of row_number

I dropped this file, and added a new one which compares the ranks of the top 5 students on an exam.

kanitw · 2018-03-18T06:32:42Z

examples/specs/window_transform_time_spent_in_class.vl.json

@@ -0,0 +1,53 @@
+{


Following the discussion here: #3199 (comment)

I'm still not convinced that this is a good example.

If you can explain a specific analysis question that this plot can answer well, I can be more convinced. (Why would you want to stack the time spent in school for the two students?)

Dropped this example.

kanitw · 2018-03-18T06:40:18Z

site/docs/transform/window.md

+```
+
+
+### Difference from Total


An improved window_transform_movie_mean_difference.vl.json is a fair game for this one. (Difference from mean)

I'd put this one as the first example in the docs, as it seems the most common.

kanitw

Also make sure that window is listed on the menu on the left. (See docs.html).

Here are some more comments after seeing which commits are new :)

kanitw · 2018-03-18T06:46:19Z

src/compile/data/window.ts

-  constructor(private transform: WindowTransform) {
-    super();
+  constructor(parent: DataFlowNode, private transform: WindowTransform) {
+    super(parent);
  }

  public producedFields() {
    const out = {};
    this.transform.window.forEach(element => {


element => windowFieldDef?

kanitw · 2018-03-18T06:46:34Z

src/compile/data/window.ts

    });

    return out;
  }

+  private getDefaultName(window: WindowFieldDef): string {


window => windowFieldDef

kanitw · 2018-03-18T06:46:48Z

src/compile/data/window.ts

@@ -43,7 +47,7 @@ export class WindowTransformNode extends DataFlowNode {
    const sortFields: string[] = [];
    const sortOrder: VgComparatorOrder[] = [];
    if (this.transform.sort !== undefined) {
-      for (const compField of this.transform.sort.compare) {
+      for (const compField of this.transform.sort) {


compField => sortField

kanitw

Thanks for working so hard, I made another pass over the new commit and have some more comments.

kanitw · 2018-03-18T17:17:12Z

src/transform.ts

   */
  param?: number;

  /**
-   * The data fields for which to compute aggregate or window functions. Field can be omitted for operations that do not
-   * operate over a specific data field, including count, rank, and dense_rank.
+   * The data field for which to compute the aggregate or window function. This can be null for functions that do not operate over a field such as `count`, `rank`, `dense_rank`.


null => omitted

kanitw · 2018-03-18T17:19:12Z

src/transform.ts

   */
  field?: string;

  /**
-   * The output name for each field. If none is defined will use the format op_field. For example, count_field for count,
-   *  and sum_field for sum.
+   *  The output name for each field. If non specified will use the format `window_op_field` for example, `count_field` for count and `sum_field` for sum.


Can you make as required by removing question mark below? (Yes -- we should still autogenerate it if as is missing, but JSON schema to enforce people to specify it, so that people write better specs.)

kanitw · 2018-03-18T17:20:16Z

src/transform.ts

@@ -146,12 +143,12 @@ export interface WindowTransform {
  ignorePeers?: boolean;

  /**
-   * The fields to group by.
+   * The names of the data fields to partioin the objects into seprate windows. If not specified, everything will be in a single group.


The data fields for partitioning the data objects into separate windows. If unspecified, all data points will be a single group.

kanitw · 2018-03-18T17:20:59Z

src/transform.ts

   */
  groupby?: string[];

  /**
-   * The definitions of how to sort each of the fields in the window.
+   * A definition for sorting the objects within the window. Equivalent objects are considered a peer (Look at ignorePeers). If left undefined, the order of items in the window is undefined.


A definition for sorting the data objects (add data)

if left undefined => If undefined

kanitw · 2018-03-18T17:23:27Z

src/transform.ts

@@ -110,20 +111,17 @@ export interface WindowFieldDef {
  op: AggregateOp | WindowOnlyOp;

  /**
-   *  Parameter values for the window functions. Parameter value can be null for operations that do not accept a
-   *  parameter.
+   *  Parameter values for the window functions. Parameter value can be omitted for operations that do not accept a parameter.


Please refer to the operation / parameter table.

Also, I want to be able to read this and know if it is ever required.

For ones that don't have param, then obviously this property will be "ignored" -- not just "can be omitted"

For ones that do have param, are they ever required, or are they always optional?

Please make this clear (Note that Vega docs isn't very clear in this aspect too, please experiment and help jeff fix Vega docs :p)

kanitw · 2018-03-18T17:23:49Z

src/transform.ts


+export type WindowOnlyOp = 'row_number' | 'rank' | 'dense_rank' | 'percent_rank' | 'cume_dist'


Put this right above WindowTransform?

kanitw · 2018-03-18T17:26:49Z

src/transform.ts

@@ -135,8 +133,7 @@ export interface WindowTransform {
  window: WindowFieldDef[];

  /**
-   * The frame for the window, if none is set the default is `[null, 0]` everything before the
-   * current item.
+   * A two element specification about how large the sliding window is. The first element indicates the start and the second element indicates the end. If `null` is specified for the start, it will include everything before the current point. If `null` is specified for the end, it will include everything after the endpoint. For example a frame of `[-5,5]` says the window should include 5 previous objects and 5 after objects. The default is `[null, 0]`, which means include everything in the window. `[null, null]` would mean include everything in the window.


The default is [null, 0], which means include everything in the window. [null, null] would mean include everything in the window.

This is inaccurate. Your text basically says that [null, 0] and [null,null] are the same. Why not just copy text from Vega docs https://vega.github.io/vega/docs/transforms/window/.

Maybe use "data objects" over just "objects" though

Another thing to change is that we always use the following format for default values:

__Default value:__: `[null, 0]` (includes the current object and all preceding objects)

(Please make sure that you use this format for all properties.)

Sorry, I thought the default was [null, null] realized it was [null, 0] so I quickly changed it, but forgot to update the description. I'll update this.

kanitw · 2018-03-18T17:30:15Z

site/docs/transform/window.md

+
+## <a name="ops"></a> Window Only Operation Reference
+
+The valid operations include all [valid aggregate operations](../aggregate/#ops) plus the following window operations.


broken link -- I think aggregate.html#ops is the right one, but please run yarn run site to check.

kanitw · 2018-03-18T17:37:50Z

Note that I change merge target to a new feature branch, but some comments (like [this one]) got collapsed, but still need to be addressed.

AkshatSh · 2018-03-19T06:51:14Z

Resolved all the comments. I also added a couple examples that will hopefully show case this transform better. I have also displayed all the examples, and their vega-lite specs in the window.md documentation file.

Let me know your thoughts!

kanitw

Thanks! I think we should be ready to merge in 1-2 more revisions.

The examples are clearly improved, but still need to be revised.

-[ ] Please only use layer when you really have layers.

For description of each property, could you please compare them with Vega docs and make sure you have equal amount of information? -- I'm not sure why you have to totally rewrite a lot of them. As a result, some important information are accidentally dropped. (We use slightly different format so it shouldn't be all copy and paste. Plus, we have our own default value format. However, we shouldn't lose important bit of information for each of those too.)
This comment is not fully addressed. (I still think the example should be removed though -- but please file a bug about it.)

Please take your time to polish this PR. (The latest revision seems a bit rushed.)

Note that you're no longer 100% blocking people as I have merged the implementation into a feature branch so people can already use window. (Yes, having docs will help them, but it's not like they can't do work anymore.)

Thank you so much for helping. I'm sure we can get this merged very soon!

kanitw · 2018-03-19T16:58:16Z

examples/specs/window_transform_movie_mean_difference.vl.json

                "type": "quantitative",
-                "scale": { "domain": [-5, 5] },
-                "axis": { "title": "Rating Delta" }
+                "scale": { "domain": [7, 10] },


Using "bar" with scale not starting from zero is misleading as the ratio between bar length do not reflect their true ratio.

Please use domain: [0, 10]

kanitw · 2018-03-19T16:59:05Z

site/docs/transform/window.md

-        "op": "sum",
-        "field": "x",
-        "as": "total"
+{


the div example already include source code -- why do you have to include the code again?

kanitw · 2018-03-19T16:59:36Z

site/docs/transform/window.md

+## Other examples
+
+Here is an example where the window_transform can be used to get the average rating for a film during different years.


window_transform => window transform

kanitw · 2018-03-19T17:00:00Z

src/transform.ts

@@ -103,6 +100,20 @@ export interface AggregatedFieldDef {
  as: string;
 }

+
+export type WindowOnlyOp =
+  |'row_number'


Why starting with |

Interesting. I don't know what's the rationale for transform.d.ts though.
I'd argue that this is a bad style, so we shouldn't follow it.

That's the style in vega-typings. It might be automatically generated by prettier over there. You can ignore the style for Vega-Lite.

kanitw · 2018-03-19T17:01:16Z

src/transform.ts

@@ -111,19 +122,19 @@ export interface WindowFieldDef {
  op: AggregateOp | WindowOnlyOp;

  /**
-   *  Parameter values for the window functions. Parameter value can be omitted for operations that do not accept a parameter.
+   *  Please refer to the operation/parameter table. Parameter values for the window functions. Parameter value can be omitted for operations that do not accept a parameter. The spec will be invalid if any function that requires a parameter is unspecified.


Please refer to the operation/parameter table.

It's weird description to say refer first. Better describe what it is first and say this later.

The spec will be invalid if any function that requires a parameter is unspecified.

This seems too extreme. It should just be ignored without failing.

kanitw · 2018-03-19T17:06:18Z

src/transform.ts

   */
  ignorePeers?: boolean;

  /**
-   * The names of the data fields to partioin the objects into seprate windows. If not specified, everything will be in a single group.
+   * The data fields for partitioning the data objects into separate windows. If unspecified, all data points will be a single group.


If unspecified, a single group containing all data objects will be used.

kanitw · 2018-03-19T17:25:44Z

examples/specs/window_transform_average_rating.vl.json

@@ -7,7 +7,8 @@
        "values": [
            { "name": "Movie 1", "Rating": 9, "Year": 2016 },
            { "name": "Movie 2", "Rating": 3, "Year": 2016 },
-            { "name": "Movie 3", "Rating": 5, "Year": 2015 }
+            { "name": "Movie 3", "Rating": 5, "Year": 2015 },
+            { "name": "Movie 4", "Rating": 2, "Year": 2015 }
        ]
    },
    "layer": [{


Not sure why you use layer and only have one layer.

That said, a better plot would be overlaying it with ticks showing AverageYearRating.

kanitw · 2018-03-19T17:31:29Z

examples/specs/window_transform_movie_mean_difference.vl.json

@@ -1,6 +1,6 @@
 {
    "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
-    "description": "Bar graph showing how each movie is different from the average movie rating",
+    "description": "Bar graph showing how each of the 'really good' movies is different from the average movie rating. Really good is defined to differ from the average movie rating by more than 2.5 points.",


This plot would benefit from another layer of rule that show global average rating (and perhaps another layer of text to label the average)

kanitw · 2018-03-19T17:39:21Z

site/docs/transform/window.md

    }],
    "frame": [null, null]
  },
  {
-    "calculate": "(datum.total - datum.x)/dataum.total",
-    "as": "Percent difference from total"
+    "calculate": "(datum.total - datum.x)/dataum.average * 100",


"dataum"

also the example above doesn't have field "x"

Please make sure to organize sections in a sensible way.

This is not addressed yet...

kanitw · 2018-03-19T17:39:59Z

site/docs/transform/window.md

+## Other examples
+
+Here is an example where the window_transform can be used to get the average rating for a film during different years.


Why is this "other example"? This is another example of difference from mean. Seems like the DIV tag is also pointing to the same example as above.

I'd say group this in the ### Difference from mean section.

In fact, I'd say that remove the "Movie 1, Movie 2, Movie 3, Movie 4" example as it's as interesting as the real one.

If your point is to show that you can group by year, you can create multiple variations of the same example like:

no group by and use the value to filter

group by year and use the value to filter

no group by, but visualize residual (rating - mean_rating) instead of just filtering.

This way users can easily see the changes without having to totally learn about a totally different example.

modified: build/vega-lite-schema.json modified: site/docs/transform/window.md modified: src/compile/data/window.ts modified: src/transform.ts modified: src/vega.schema.ts deleted: src/window.ts

(It exists in Vega, but not Vega-Lite)

kanitw reviewed Nov 15, 2017

View reviewed changes

kanitw reviewed Nov 16, 2017

View reviewed changes

AkshatSh force-pushed the ak/WindowTransform branch 2 times, most recently from ad3d465 to 7b0c01f Compare January 12, 2018 23:42

kanitw reviewed Jan 23, 2018

View reviewed changes

kanitw mentioned this pull request Jan 28, 2018

Document & unhide stack transform #3311

Closed

1 task

AkshatSh force-pushed the ak/WindowTransform branch 2 times, most recently from f5bf7f8 to 1c7abee Compare February 5, 2018 20:07

AkshatSh force-pushed the ak/WindowTransform branch 2 times, most recently from 2dc5f98 to 2e8dd98 Compare February 9, 2018 19:08

kanitw force-pushed the ak/WindowTransform branch 2 times, most recently from bc51406 to 7ac5053 Compare February 10, 2018 20:46

kanitw requested changes Feb 10, 2018

View reviewed changes

kanitw changed the title ~~[WIP] Added files for window transform~~ [WIP] Add window transform Mar 3, 2018

kanitw mentioned this pull request Mar 5, 2018

[2.5?] Composite Mark #3461

Closed

6 tasks

AkshatSh force-pushed the ak/WindowTransform branch from 7ac5053 to ebe93d4 Compare March 18, 2018 02:17

kanitw requested changes Mar 18, 2018

View reviewed changes

AkshatSh force-pushed the ak/WindowTransform branch from 3d63cac to 8d90ba0 Compare March 18, 2018 08:30

kanitw reviewed Mar 18, 2018

View reviewed changes

kanitw changed the base branch from master to 2.x-window March 18, 2018 17:36

kanitw changed the title ~~[WIP] Add window transform~~ [WIP] Revise window transform + Add Docs / Examples Mar 18, 2018

kanitw mentioned this pull request Mar 18, 2018

Support window in the transform array #2488

Closed

kanitw requested changes Mar 19, 2018

View reviewed changes

AkshatSh and others added 25 commits March 25, 2018 16:41

Added documentation for window transform

bfde11a

Examples for WindowTransform

6ee30ec

Resolved code comments

753452c

modified: build/vega-lite-schema.json modified: site/docs/transform/window.md modified: src/compile/data/window.ts modified: src/transform.ts modified: src/vega.schema.ts deleted: src/window.ts

Updated examples and added new exampels for window transform

600b901

Updated code comments, and updated docs to contain examples

4edebfd

Updated vega-lite-schema.json

010d953

Updated examples, and resolved some issues

52b2dd7

included build file

d7d7476

removed json blobs

2d85080

Resolving comments

49260ca

[WIP] resolving comments

6e80eab

Don't include non-existing type template

0b5fe97

(It exists in Vega, but not Vega-Lite)

fixed example name in window.md

cc5d7ee

fixed mark issues for tests

5b791d7

Update doc versions and TOC

a5fc1ca

Simplify window_transform_activities

c33a33d

Add Rule to mean difference example

af7a3e1

Update examples more

a488051

Resolve broken links

f22bab6

Added introduction before specs in window.md

8bdc1fa

fixed default value false issue

b1827df

added introduction for examples in window.md

0b660e9

fixed style on examples

4214e3f

renamed examples

749b3cc

Fix descriptions in the schema

2634c56

AkshatSh force-pushed the ak/WindowTransform branch from 8687adb to 2634c56 Compare March 25, 2018 23:42

AkshatSh mentioned this pull request Mar 26, 2018

Window Transform Documentation and Examples #3571

Merged

kanitw approved these changes Mar 26, 2018

View reviewed changes

kanitw closed this Mar 26, 2018

kanitw deleted the ak/WindowTransform branch March 26, 2018 03:53


		export type WindowOnlyOp = 'row_number' \| 'rank' \| 'dense_rank' \| 'percent_rank' \| 'cume_dist'


		## <a name="ops"></a> Window Only Operation Reference

		The valid operations include all [valid aggregate operations](../aggregate/#ops) plus the following window operations.

		## Other examples

		Here is an example where the window_transform can be used to get the average rating for a film during different years.


		### Percent of Total

		```json

[WIP] Revise window transform + Add Docs / Examples #3199

[WIP] Revise window transform + Add Docs / Examples #3199

Conversation

AkshatSh commented Nov 15, 2017 • edited by kanitw Loading

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw commented Jan 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkshatSh Jan 24, 2018 • edited Loading

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw Mar 18, 2018 • edited by AkshatSh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw commented Feb 10, 2018 • edited by AkshatSh Loading

kanitw commented Mar 5, 2018

kanitw left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw Mar 18, 2018 • edited by AkshatSh Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw Mar 18, 2018 • edited Loading

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

[WIP] Revise `window` transform + Add Docs / Examples #3199

[WIP] Revise `window` transform + Add Docs / Examples #3199

AkshatSh commented Nov 15, 2017 •

edited by kanitw

Loading

AkshatSh Jan 24, 2018 •

edited

Loading

kanitw Mar 18, 2018 •

edited by AkshatSh

Loading

kanitw commented Feb 10, 2018 •

edited by AkshatSh

Loading

kanitw left a comment •

edited

Loading

kanitw Mar 18, 2018 •

edited by AkshatSh

Loading

kanitw Mar 18, 2018 •

edited

Loading