Geo #2734

willium · 2017-08-01T02:56:46Z

Add Geo to Vega-Lite

kanitw · 2017-08-01T02:59:01Z

src/compile/projection/parse.ts

+  if (model instanceof UnitModel) {
+    model.component.projection = parseUnitProjection(model, config);
+  } else {
+    const mergedProjection = parseNonUnitProjections(model);


model.component.projection =

ah right, I was going to check if undefined

kanitw · 2017-08-01T03:00:19Z

src/compile/projection/parse.ts

+    // TODO: make sure this actually works for both kinds of lookups, with GeoJSON transform, and with basic projection
+    const data = model.requestDataName(MAIN);
+
+    const width = model.getSizeSignalRef('width');


I suggest using {signal: model.getName('width')} as I am about to restrict getSizeSignalRef() for using in assemble only.

If you haven't, make sure that in assemble, you replace size signals with updated names.

kanitw · 2017-08-01T03:01:23Z

src/compile/projection/parse.ts

+
+    const isGeoshapeMark = markDef && markDef.type === GEOSHAPE;
+    const hasEncodedProjection = encoding && [X, Y, SHAPE].some((channel) => isProjectionFieldDef(encoding[channel]));
+    const inheritedProjection = config && config.projection;


config is never null -- you can just read config.projection when needed.

kanitw · 2017-08-01T03:02:00Z

src/compile/projection/parse.ts

+  }
+}
+
+function parseUnitProjection(model: UnitModel, config: Config): ProjectionComponent {


No need to take config as parameter. You can access it from model.config.
The init part already passed config to all models in the model tree.

kanitw · 2017-08-01T03:03:49Z

src/compile/projection/parse.ts

+  const merged = model.children.reduce((projections, child) => {
+    const projection = child.component.projection;
+    if (projection) {
+      projections.forEach((other) => {


Here you seems to always merge -- see parseNonUnitScaleCore how I make two passes over the children. The first pass checks whether I can merge all of them. If can merge, then make second pass to really merge.

kanitw · 2017-08-01T03:04:38Z

src/compile/scale/parse.ts

-  return SCALE_CHANNELS.reduce((scaleComponents: ScaleComponentIndex, channel: ScaleChannel) => {
+  const scaleComponents: ScaleComponentIndex = {};
+  SCALE_CHANNELS.forEach((channel: ScaleChannel) => {
+    if (mark === GEOSHAPE && channel === SHAPE) {


Add comment why geoshape's shape is always totally skipped?

willium · 2017-08-05T02:46:07Z

src/compile/scale/parse.ts

    let fieldDef: FieldDef<string>;
    let specifiedScale: Scale = {};

    const channelDef = encoding[channel];

-    if (isFieldDef(channelDef)) {
+    if (isFieldDef(channelDef) && isScaleFieldDef(channelDef)) {


This was giving me errors in my editor (the linter), but now I wonder if this is what is causing my issues @kanitw

What happen if scale is undefined?

I dont think its causing the issues. I slightly rewrote it and the issues are the same

kanitw · 2017-08-06T01:23:04Z

src/encoding.ts

   */
-  shape?: Conditional<LegendFieldDef<F>, ValueDef<string>>; // TODO: maybe distinguish ordinal-only
+  shape?: Conditional<FieldDef<F>, ValueDef<string>>; // TODO: maybe distinguish ordinal-only


This is the problematic line as shape can still be LegendFieldDef for point.

kanitw

Quick pass over the documentation.

I will spend some more time to thoroughly review the code later this week.

kanitw · 2018-01-14T23:11:41Z

src/fielddef.ts

@@ -143,6 +143,7 @@ export interface FieldDefBase<F> {
 export interface FieldDef<F> extends FieldDefBase<F> {
  /**
   * The encoded field's type of measurement (`"quantitative"`, `"temporal"`, `"ordinal"`, or `"nominal"`).
+   * It can also be a geo type (`"latitude"`, `"longitude"`, and `"geojson"`) when applicable.


Can you describe specifically what "when applicable" mean? (So that users understand right away and do not have to try to find other docs to read.)

I don't think this is a good idea. Adding anything more is just weirdly specific. Here's what I came up with, but it's honestly more confusing.

* It can also be a geo type (`"latitude"`, `"longitude"`, and `"geojson"`) when projecting geographical coordinates using a `point` mark (on `x`, and `y` channels), a `rule` mark (on `x`, `x2`, `y`, and `y2` channels) or projecting a GeoJSON shapefile on a `geoshape` mark (on the `shape` channel).

Cut this part -- it's too much

using a point mark (on x, and y channels), a rule mark (on x, x2, y, and y2 channels) or projecting a GeoJSON shapefile on a geoshape mark (on the shape channel)."

and then paraphrase this part to be slightly human-friendly and link to related concept

when projecting geographical coordinates

I don't really understand what you're saying

Sorry, I mean something like this:

It can also be a geographic type ("latitude", "longitude", and "geojson") for using with geographic projection

and link projection to projection docs

("when applicable" is vague and doesn't convey much information :D)

kanitw · 2018-01-14T23:13:09Z

src/encoding.ts

   * `"circle"` (default), `"square"`, `"cross"`, `"diamond"`, `"triangle-up"`,
   * or `"triangle-down"`, or else a custom SVG path string.
   * __Default value:__ If undefined, the default shape depends on [mark config](config.html#point-config)'s `shape` property.
+   * For `geoshape` marks it should be a fielddef of the geojson data


No description should be added below "Default value:" line

Could you please move it above and add a line break between the main description and the "Default value:" (Yeah we should have added it prior to this PR.)

fielddef => field definition

kanitw · 2018-01-14T23:13:36Z

src/fielddef.ts

      return true;
    case 'quantitative':
      return !!fieldDef.bin;
-    case 'temporal':
+      case 'latitude':


inconsistent tabbing

kanitw · 2018-01-14T23:17:12Z

src/projection.ts

+   * The type of the projection. The default is "mercator".
+   */
+  type?: ProjectionType;
+  /**


Please add line breaks between properties and JS Docs of the next properties

kanitw · 2018-01-14T23:19:27Z

src/spec.ts

@@ -103,6 +104,11 @@ export interface GenericUnitSpec<E extends Encoding<any>, M> extends BaseSpec, L
   */
  encoding: E;

+  /**
+   * A geo projection


An object defining properties of geographic projection.

Please also describe more if this can be null or something?
Does it work only for certain type of marks? (If all marks, ignore my comment.)

What's the __Default value:__, is there any case it is generated by default?

kanitw · 2018-01-14T23:25:23Z

site/docs/mark/geoshape.md

+```
+
+The `geoshape` mark represents an arbitrary shapes whose geometry is determined by specified GeoJSON shape data.
+


Need one or a few examples. (All other mark pages have at least one example.)

kanitw · 2018-01-14T23:29:11Z

site/docs/encoding/type.md

+
+{% include table.html props="type" source="FieldDef" %}
+
+**Note**:


Thanks for adding this note. This is definitely useful to add.

A few thoughts:

We should add it to type.md too

For this page, I think maybe it's better to add this description to the JSDoc in the FieldDef interface so the explanation appears in the table. Plus, Altair users can directly benefit from this explanation.

Can you clarify what you mean? (also do you mean types.md?)

There is type.md

You can put the note in FieldDef interface in fielddef.ts instead of here.

kanitw · 2018-01-14T23:33:12Z

site/docs/projection.md

+permalink: /docs/projection.html
+---
+## Projection Overview
+Projection's are specified at the mark specification level, alongside encoding.


I think we usually begin a docs by explaining the concept. You can copy some of the text from https://vega.github.io/vega/docs/projections

specified at the mark specification level, alongside encoding

Also, there is no concept of "mark specification". I think you only mean specification. Please also make it clear whether all types of specification support projection. (Is it only unit and layer or all types of specification?)

kanitw · 2018-01-14T23:33:27Z

site/docs/projection.md

+## Projection Properties
+{% include table.html props="type,clipAngle,clipExtent,center,rotate,precision" source="Projection" %}
+
+


Missing example

kanitw · 2018-01-14T23:34:55Z

site/docs/projection.md

+
+{:#properties}
+## Projection Properties
+{% include table.html props="type,clipAngle,clipExtent,center,rotate,precision" source="Projection" %}


From Vega docs,

In addition to the shared properties above, the following properties are supported for specific projection types in the d3-geo-projection library: coefficient, distance, fraction, lobes, parallel, radius, ratio, spacing, tilt.

Do we support these properties too?

We don't currently. Do you want to? I can add them in projection.ts

I think so.

kanitw · 2018-01-14T23:37:02Z

src/projection.ts

+
+export interface Projection {
+  /**
+   * The type of the projection. The default is "mercator".


Add link to the section that describe all supported projection type?

Also use __Default value:__ to describe default value. -- same for other properties in this interface.

kanitw · 2018-01-15T00:30:54Z

Related to Geo #2734 (comment), I think you have to update table in spec.md and perhaps layer.md to include the new projection property. (Maybe there are other properties not added yet as well.)

kanitw

Ok. I actually have sometimes so here are some more comments.

I still need to look at src/compile/projection/parse.ts and examples

kanitw · 2018-01-15T00:00:49Z

src/compile/data/geojson.ts

+    const geo = model.reduceFieldDef((rel, fieldDef, channel) => {
+      if ((contains([X, Y, X2, Y2], channel) && contains([LATITUDE, LONGITUDE], fieldDef.type))
+        || (channel === SHAPE && fieldDef.type === GEOJSON)) {
+        rel[fieldDef.type] = fieldDef.field;


I wonder if using dictionary here would make it work when we want to use both x/y and y2/x2 (e.g., for line segment rules)?

It seems like this logic will make fieldDef for x2 overrides x's?

That said, it seems to work from your example, but I wonder why. (Perhaps, we need some comment here to explain why it is okay to do it this way.

you've discovered a bug, but unfortunately it's not so easy to fix. The bug isn't about whether or not we can project rule, but instead how fit is computed (it appears to work since fit on X2 and Y2 is similar to X and Y). You're correct in your assessment that X2 would override X (my bad).

this is non trivial. I will have to think about it more.

kanitw · 2018-01-15T00:03:45Z

src/compile/data/geopoint.ts

+    const points: TypeField[] = [];
+
+    const possiblePairs: SingleDefChannel[][] = [[X, Y], [X2, Y2]];
+    possiblePairs.forEach((posssiblePair) => {


Yeah, I think map is a bad idea here.

kanitw · 2018-01-15T00:09:05Z

src/compile/legend/parse.ts

@@ -51,6 +54,10 @@ export function parseLegendForChannel(model: UnitModel, channel: NonPositionScal
  const fieldDef = model.fieldDef(channel);
  const legend = model.legend(channel);

+  if (!model.getScaleComponent(channel)) {


Move the logic to parseUnitLegend so that the structure of both parseUnitLegend and parseUnitAxis are similar?

kanitw · 2018-01-15T00:11:03Z

src/compile/mark/geoshape.ts

+    return {
+      ...mixins.color(model),
+      ...mixins.text(model, 'tooltip'),
+      ...mixins.nonPosition('opacity', model)


If we merge the href PR before we merge this one, we will have to add href here too :)

#3229

FYI, to make this easier for the future -- I added #3280 (comment)

kanitw · 2018-01-15T00:11:38Z

src/compile/mark/geoshape.ts

+  encodeEntry: (model: UnitModel) => {
+    const {config} = model;
+    return {
+      ...mixins.color(model),


missing a recently added ...mixins.markDefProperties(model.markDef, true)?

kanitw · 2018-01-15T00:21:20Z

src/compile/projection/assemble.ts

+  }
+
+  const projection = component.combine();
+  const {name, ...rest} = projection;


not sure why you have to extract name and rest here, simply to merge them again at the end?

I think I do for some weird reason to do with types. if I remove them from the bottom and just extend projection with the return, the type check yells at me. Basically a vega projection is all the properties of the vega-lite projection + name, size, and fit (which are algorithmically decided)

This is fine. I added a comment.

kanitw · 2018-01-15T00:23:43Z

src/compile/projection/parse.ts

+  return undefined;
+}
+
+function dryMerge(first: ProjectionComponent, second: ProjectionComponent): ProjectionComponent {


Can you add a comment to explain what dryMerge means?

Perhaps, mergeIfNoConflict or mergeIfPropertiesAreConsistent might be a better name?

kanitw · 2018-01-15T00:27:54Z

src/compile/scale/parse.ts

@@ -50,15 +52,21 @@ function parseUnitScaleCore(model: UnitModel): ScaleComponentIndex {

    const channelDef = encoding[channel];

+    // if mark is geoshape scale channel encodes the geojson


This comment reads quite confusing.

I think you mean "If mark is geoshape, we use projection instead so there is no need to generate a scale." ?

kanitw · 2018-01-15T00:33:46Z

src/projection.ts

+
+export type ProjectionType = VgProjectionType;
+
+export interface Projection {


Looks like descriptions of some properties in the Vega docs are a bit more comprehensive and have links to related bl.ock.org examples

kanitw · 2018-01-15T00:34:59Z

src/spec.ts

-  const {mark, selection, encoding, ...outerSpec} = spec;
+  // _ is used to denote a dropped property of the unit spec
+  // which should not be carried over to the layer spec
+  const {mark, selection, projection: _p, encoding, ...outerSpec} = spec;


Why should we drop projection for point overlay over lines?

(Suppose we draw lines between different cities and we want to overlay points over each city?)

kanitw

The examples look pretty impressive! I only have a few minor comments.

kanitw · 2018-01-15T03:56:44Z

examples/specs/geo_circle.vl.json

+  "$schema": "https://vega.github.io/schema/vega-lite/v2.json",
+  "width": 500,
+  "height": 300,
+  "projection": {


We should be consistent in terms of where to put projection in our example specs.

I think after transform and right before mark seems appropriate? – All other examples follow this format anyway.

kanitw · 2018-01-15T03:59:16Z

examples/specs/geo_choropleth.vl.json

+      "fields": ["rate"]
+    }
+  }],
+  "projection": {


It seems like in a lot of spec, we will just specify projection with type only. I wonder if we should make projection: string supported too so it's consistent with mark.
If you agree, feel free to file an issue so we can deal with this later.

nah. we can support that later maybe.

kanitw

parse.ts also looks reasonable, but I think we need some more comments :)

kanitw · 2018-01-15T04:27:18Z

src/compile/projection/parse.ts

+}
+
+function dryMerge(first: ProjectionComponent, second: ProjectionComponent): ProjectionComponent {
+  const properties = every(PROJECTION_PROPERTIES, (prop) => {


properties needs a better variable name.

Perhaps, allPropertiesAreConsistent or something?

kanitw · 2018-01-15T04:28:26Z

src/compile/projection/parse.ts

+    // both have property and an equal value for property
+    if (first.explicit.hasOwnProperty(prop) &&
+      second.explicit.hasOwnProperty(prop) &&
+      hash(first.get(prop)) === hash(second.get(prop))) {


Why do we have to compared the hashed value? Is that because some property can be an object?
(If so, please add a comment.)

kanitw · 2018-01-15T04:30:49Z

src/compile/projection/parse.ts

+      return first;
+    }
+  }
+  return null;


So if properties are not consistent, then we don't merge the projection at all?

(If this is intended, please add some comment + explain why this should be the behavior.)

kanitw · 2018-01-15T04:33:46Z

src/compile/projection/parse.ts

+  return undefined;
+}
+
+function dryMerge(first: ProjectionComponent, second: ProjectionComponent): ProjectionComponent {


Perhaps, mergeIfNoConflict or mergeIfPropertiesAreConsistent might be a better name?

domoritz · 2018-01-24T00:07:17Z

Add example for connected scatterplot on a map.

kanitw · 2018-01-24T00:24:29Z

site/docs/encoding/type.md

@@ -5,7 +5,12 @@ permalink: /docs/type.html
 ---

 If a field is specified, the channel definition **must** describe the encoded data's [type of measurement (level of measurement)](https://en.wikipedia.org/wiki/Level_of_measurement).
-The supported data types are: `"quantitative"`, `"temporal"`, `"ordinal"`, and `"nominal"`.
+The supported data types are: `"quantitative"`, `"temporal"`, `"ordinal"`, `"nominal"`, `"latitude"`, `"longitude"`, and `"geojson"`.


Add anchor links for the types?

kanitw

I think we can merge after fixing these minor stuff. :) 🎉

kanitw · 2018-01-24T20:28:21Z

src/compile/mark/geoshape.ts

+    const {encoding, markDef} = model;
+    const shapeDef = encoding.shape;
+
+    if ((isFieldDef(shapeDef) && shapeDef.type === GEOJSON) || markDef.type === GEOSHAPE) {


This comment seems unaddressed?

kanitw · 2018-01-24T20:32:59Z

src/compile/projection/assemble.ts

@@ -26,7 +24,7 @@ export function assembleProjectionForModel(model: Model): VgProjection[] {
  }

  const projection = component.combine();
-  const {name, ...rest} = projection;
+  const {name, ...rest} = projection;  // name is always defined


// name is always defined

This confuses me, but Dom just explained to me the real reason behind this.

Please change to .. "we need to extract name so that it is always present in the output and pass TS type validation" or something similar.

kanitw · 2018-01-24T20:36:36Z

src/compile/projection/parse.ts

@@ -66,25 +75,25 @@ function dryMerge(first: ProjectionComponent, second: ProjectionComponent): Proj
    // both have property and an equal value for property
    if (first.explicit.hasOwnProperty(prop) &&
      second.explicit.hasOwnProperty(prop) &&
+      // some properties might be signals or objects and require hashing for comparison
      hash(first.get(prop)) === hash(second.get(prop))) {


If we want exact comparison, we should use stringify here more than hash?

hash is stringify.

kanitw · 2018-01-24T20:37:47Z

src/fielddef.ts

@@ -143,7 +142,7 @@ export interface FieldDefBase<F> {
 export interface FieldDef<F> extends FieldDefBase<F> {
  /**
   * The encoded field's type of measurement (`"quantitative"`, `"temporal"`, `"ordinal"`, or `"nominal"`).
-   * It can also be a geo type (`"latitude"`, `"longitude"`, and `"geojson"`) when applicable.
+   * It can also be a geo type (`"latitude"`, `"longitude"`, and `"geojson"`) when projecting geographical coordinates using a `"point"` mark (on `"x"`, and `"y"` channels), a `"rule"` mark (on `"x"`, `"x2"`, `"y"`, and `"y2"` channels) or projecting a GeoJSON shapefile on a `"geoshape"` mark (on the `"shape"` channel).


"when a geographic projection is applied"?

(and link to projection page)

kanitw · 2018-01-24T20:39:24Z

src/projection.ts

   */
  precision?: String;
+
+  /** The following properties are all supported for specific types of projections. Consult the d3-geo-projection library for more information: https://github.com/d3/d3-geo-projection */


If you want do it a lazy way like this, use /* not /** otherwise this comment will be attached to only coefficient, which is not what you want.

kanitw · 2018-01-24T20:39:39Z

src/vega.schema.ts

@@ -150,6 +150,17 @@ export type VgProjection = {
   * Used in conjunction with fit, provides the width and height in pixels of the area to which the projection should be automatically fit.
   */
  size?: VgSignalRef | (number | VgSignalRef)[];
+
+  /** The following properties are all supported for specific types of projections. Consult the d3-geo-projection library for more information: https://github.com/d3/d3-geo-projection */


kanitw · 2018-01-24T20:40:37Z

site/docs/mark/text.md

@@ -43,6 +43,13 @@ Mapping a field to `text` channel of text mark sets the mark's text value. For e
 <span class="vl-example" data-name="text_scatterplot_colored"></span>


+## Geo Text
+
+With the [types](type.html) `longitude` and `latitude` instead of `x` and `y` and a corresponding [projection](projection.html), we can show text at accurate locatins. The example below shows the name of every US state capital at the location of the capital.


kanitw reviewed Aug 1, 2017

View reviewed changes

willium force-pushed the geo-lite branch 10 times, most recently from 86c9f35 to 71b8d5d Compare August 5, 2017 02:44

willium commented Aug 5, 2017

View reviewed changes

willium force-pushed the geo-lite branch 6 times, most recently from cdd833f to df923c8 Compare August 6, 2017 00:23

kanitw reviewed Aug 6, 2017

View reviewed changes

willium force-pushed the geo-lite branch 11 times, most recently from 4828f6c to 5abd47e Compare August 10, 2017 03:44

willium force-pushed the geo-lite branch from ef550a2 to 2d17751 Compare January 14, 2018 21:13

kanitw requested changes Jan 14, 2018

View reviewed changes

kanitw reviewed Jan 14, 2018

View reviewed changes

vega deleted a comment from willium Jan 14, 2018

kanitw requested changes Jan 15, 2018

View reviewed changes

kanitw reviewed Jan 15, 2018

View reviewed changes

willium force-pushed the geo-lite branch from 2d17751 to 292cd78 Compare January 21, 2018 05:05

kanitw reviewed Jan 24, 2018

View reviewed changes

domoritz force-pushed the geo-lite branch 2 times, most recently from 4e9bb76 to 23df794 Compare January 24, 2018 17:22

kanitw requested changes Jan 24, 2018

View reviewed changes

willium force-pushed the geo-lite branch from d952daf to 3efb6dc Compare January 24, 2018 22:14

willium and others added 10 commits January 25, 2018 09:33

add geo example specs

2a71203

add geo implementation

f7fb34f

add geo tests

1b0eb5d

add geo docs

31c3135

add geo compiled specs and svgs

6f162f7

Revisions of implementation

77dee7a

Add geo examples to point, line, and text

753f377

add table and example

4cc96bb

Fix typo

f121635

simplify postEncodingTransform logic for geoshape

1a9613c

domoritz force-pushed the geo-lite branch from 3efb6dc to 1a9613c Compare January 25, 2018 17:38

domoritz merged commit 1a9613c into master Jan 25, 2018

kanitw deleted the geo-lite branch January 25, 2018 18:00

kachkaev mentioned this pull request Jan 25, 2018

Geo gicentre/elm-vega#35

Closed

dangotbanned mentioned this pull request Feb 11, 2025

Add Species Habitat Dataset for Faceted Map Examples vega/vega-datasets#683

Closed

5 tasks

		```

		The `geoshape` mark represents an arbitrary shapes whose geometry is determined by specified GeoJSON shape data.


		{% include table.html props="type" source="FieldDef" %}

		Note:

		## Projection Properties
		{% include table.html props="type,clipAngle,clipExtent,center,rotate,precision" source="Projection" %}

		@@ -50,15 +52,21 @@ function parseUnitScaleCore(model: UnitModel): ScaleComponentIndex {

		const channelDef = encoding[channel];

		// if mark is geoshape scale channel encodes the geojson


		export type ProjectionType = VgProjectionType;

		export interface Projection {

Geo #2734

Geo #2734

Conversation

willium commented Aug 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

willium Jan 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw Jan 14, 2018 • edited Loading

Choose a reason for hiding this comment

kanitw commented Jan 15, 2018 • edited by willium Loading

kanitw left a comment

Choose a reason for hiding this comment

kanitw Jan 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw Jan 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw Jan 15, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

domoritz commented Jan 24, 2018 • edited by willium Loading

Choose a reason for hiding this comment

kanitw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

willium commented Aug 1, 2017 •

edited

Loading

willium Jan 21, 2018 •

edited

Loading

kanitw Jan 14, 2018 •

edited

Loading

kanitw commented Jan 15, 2018 •

edited by willium

Loading

kanitw Jan 15, 2018 •

edited

Loading

kanitw Jan 15, 2018 •

edited

Loading

kanitw Jan 15, 2018 •

edited

Loading

domoritz commented Jan 24, 2018 •

edited by willium

Loading