Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by encoding should have a short-form? #4933

Closed
kanitw opened this issue May 3, 2019 · 5 comments
Closed

Sort by encoding should have a short-form? #4933

kanitw opened this issue May 3, 2019 · 5 comments
Assignees
@kanitw
Labels
P2 Important Issues that should be fixed soon RFC / Discussion 💬 For discussing proposed changes
Milestone
4.0

Comments

@kanitw
Copy link
Member

kanitw commented May 3, 2019

As I prep for the ODSC tutorial, I realize we should make shorthand for sort-by encoding as this will be way more convenient for Altair and VL-API:

sort: {encoding: 'x'} could become just sort: 'x'.

sort: {encoding: 'x', order: 'descending'} could be sort: '-x'?
@kanitw kanitw added the RFC / Discussion 💬 For discussing proposed changes label May 3, 2019
@g3o2
Copy link
Contributor

g3o2 commented May 3, 2019

Isn't sort: {encoding: 'x', order: 'descending'} itself already a shorthand for sorting by field? In addition, the minus notation seems appealing but is otherwise nowhere used in the vl schema, isn't it?

@iliatimofeev

This comment has been minimized.

Sign in to view
@kanitw

This comment has been minimized.

Sign in to view
@kanitw kanitw mentioned this issue May 28, 2019
Closed
@kanitw
Copy link
Member Author

kanitw commented May 28, 2019

The discussion in vega/altair#884 (comment) also favors this issue.

@kanitw kanitw added this to the 4.0 milestone Jun 2, 2019
@kanitw kanitw changed the title Sort by encoding should have a short-form Sort by encoding should have a short-form? Jun 2, 2019
@kanitw kanitw added the P2 Important Issues that should be fixed soon label Jun 2, 2019
@kanitw kanitw self-assigned this Jun 6, 2019
kanitw added a commit that referenced this issue Jun 29, 2019
@kanitw
feat: Add a short-form for sort by encoding (e.g., sort: "x", `sort…
c21f90e 
…: "-x"`)

Fix #4933
@kanitw kanitw mentioned this issue Jun 29, 2019
Merged
@kanitw
Copy link
Member Author

kanitw commented Jun 29, 2019

Fixed in #5134.

@kanitw kanitw closed this as completed Jun 29, 2019
kanitw added a commit that referenced this issue Jul 6, 2019
@kanitw
feat: Add a short-form for sort by encoding (e.g., sort: "x", `sort…
eb164e1 
…: "-x"`)

Fix #4933
kanitw added a commit that referenced this issue Jul 6, 2019
@kanitw
feat: Add a short-form for sort by encoding (e.g., sort: "x", `sort…
5a6d7c2 
…: "-x"`)

Fix #4933
kanitw added a commit that referenced this issue Jul 6, 2019
@kanitw
feat: Add a short-form for sort by encoding (e.g., sort: "x", `sort…
5c339f3 
…: "-x"`)

Fix #4933
domoritz pushed a commit that referenced this issue Jul 6, 2019
@kanitw @domoritz
feat!: supporting channel name string for sorting by another encoding…
1bd7037 
… (e.g., `sort: "x"`, `sort: "-x"`) (#5134)

Fixes #4933
kanitw added a commit that referenced this issue Jul 20, 2019
@kanitw
feat!: supporting channel name string for sorting by another encoding…
3a813df 
… (e.g., `sort: "x"`, `sort: "-x"`) (#5134)

Fixes #4933
domoritz pushed a commit that referenced this issue Jul 25, 2019
@kanitw @domoritz
feat!: supporting channel name string for sorting by another encoding…
471228e 
… (e.g., `sort: "x"`, `sort: "-x"`) (#5134)

Fixes #4933
domoritz pushed a commit that referenced this issue Jul 25, 2019
@kanitw @domoritz
feat!: supporting channel name string for sorting by another encoding…
11c4191 
… (e.g., `sort: "x"`, `sort: "-x"`) (#5134)

Fixes #4933
willium pushed a commit that referenced this issue Jul 25, 2019
@kanitw @willium
feat!: supporting channel name string for sorting by another encoding…
cef6c4c 
… (e.g., `sort: "x"`, `sort: "-x"`) (#5134)

Fixes #4933
@kanitw kanitw modified the milestones: 4.1, 4.0 Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanitw kanitw

Labels
P2 Important Issues that should be fixed soon RFC / Discussion 💬 For discussing proposed changes
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@kanitw @iliatimofeev @g3o2