Skip to content

Commit

Permalink
remove test hack line
Browse files Browse the repository at this point in the history
  • Loading branch information
hydrosquall committed Jan 25, 2025
1 parent 71cf1df commit 6350cdb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ export function stack(m: Mark | MarkDef, encoding: Encoding<string>): StackPrope

// TODO: Figure out why groupBy is only sometimes necessary?
// Unclear why the test case and the bug report differ in whether a groupBy should be supplied to vega or not
const shouldAddPolarGroupBy = dimensionField === 'dir' || (fieldChannel === dimensionChannel);
// const shouldAddPolarGroupBy = dimensionField === 'dir' || (fieldChannel === dimensionChannel);
const shouldAddPolarGroupBy = (fieldChannel === dimensionChannel);

Check warning on line 188 in src/stack.ts

View workflow job for this annotation

GitHub Actions / Runtime, Linting, and Coverage

Replace `(fieldChannel·===·dimensionChannel)` with `fieldChannel·===·dimensionChannel`

// if (!hasSameDimensionAndStackedField) {
if (!hasSameDimensionAndStackedField && (isPolar ? (shouldAddPolarGroupBy) : true)) {

Check warning on line 191 in src/stack.ts

View workflow job for this annotation

GitHub Actions / Runtime, Linting, and Coverage

Replace `(shouldAddPolarGroupBy)` with `shouldAddPolarGroupBy`
Expand Down

0 comments on commit 6350cdb

Please sign in to comment.