Skip to content

Commit

Permalink
fix: mark discrete axes of rect marks use axis's zindex = 1 by default (
Browse files Browse the repository at this point in the history
#5153)

* fix: mark discrete axes of rect marks use axis's zindex = 1 by default

* [Travis] Update examples (build: 24261)
  • Loading branch information
kanitw authored and domoritz committed Jul 25, 2019
1 parent 259d353 commit 2fe10b2
Show file tree
Hide file tree
Showing 45 changed files with 84 additions and 66 deletions.
2 changes: 1 addition & 1 deletion examples/compiled/concat_marginal_histograms.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/concat_marginal_histograms.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@
"labelFlush": true,
"labelOverlap": true,
"tickCount": {"signal": "ceil(concat_1_concat_0_width/10)"},
"zindex": 0
"zindex": 1
},
{
"scale": "concat_1_concat_0_y",
Expand All @@ -272,7 +272,7 @@
"title": "Rotten_Tomatoes_Rating (binned)",
"labelOverlap": true,
"tickCount": {"signal": "ceil(concat_1_height/10)"},
"zindex": 0
"zindex": 1
}
]
},
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/facet_cross_independent_scale.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/facet_cross_independent_scale.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -196,14 +196,14 @@
"labelAlign": "right",
"labelAngle": 270,
"labelBaseline": "middle",
"zindex": 0
"zindex": 1
},
{
"scale": "child_y",
"orient": "left",
"grid": false,
"title": "b",
"zindex": 0
"zindex": 1
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/interactive_concat_layer.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/interactive_concat_layer.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@
"labelFlush": true,
"labelOverlap": true,
"tickCount": {"signal": "ceil(concat_0_width/10)"},
"zindex": 0
"zindex": 1
},
{
"scale": "concat_0_y",
Expand All @@ -235,7 +235,7 @@
"title": "Rotten_Tomatoes_Rating (binned)",
"labelOverlap": true,
"tickCount": {"signal": "ceil(concat_0_height/10)"},
"zindex": 0
"zindex": 1
}
],
"legends": [
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/layer_text_heatmap.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/layer_text_heatmap.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,15 @@
"labelAngle": 270,
"labelBaseline": "middle",
"labelOverlap": true,
"zindex": 0
"zindex": 1
},
{
"scale": "y",
"orient": "left",
"grid": false,
"title": "Origin",
"labelOverlap": true,
"zindex": 0
"zindex": 1
}
],
"legends": [
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/rect_binned_heatmap.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/rect_binned_heatmap.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
"labelFlush": true,
"labelOverlap": true,
"tickCount": {"signal": "ceil(width/10)"},
"zindex": 0
"zindex": 1
},
{
"scale": "y",
Expand All @@ -155,7 +155,7 @@
"title": "Rotten_Tomatoes_Rating (binned)",
"labelOverlap": true,
"tickCount": {"signal": "ceil(height/10)"},
"zindex": 0
"zindex": 1
}
],
"legends": [
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/rect_heatmap.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/rect_heatmap.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,14 @@
"labelAngle": 270,
"labelBaseline": "middle",
"labelOverlap": true,
"zindex": 0
"zindex": 1
},
{
"scale": "y",
"orient": "left",
"grid": false,
"title": "Origin",
"zindex": 0
"zindex": 1
}
],
"legends": [
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/rect_heatmap_weather.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/rect_heatmap_weather.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"labelAlign": "center",
"labelBaseline": "top",
"labelOverlap": true,
"zindex": 0
"zindex": 1
},
{
"scale": "y",
Expand All @@ -110,7 +110,7 @@
"update": {"text": {"signal": "timeFormat(datum.value, '%b')"}}
}
},
"zindex": 0
"zindex": 1
}
],
"legends": [
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/rect_lasagna_future.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions examples/compiled/rect_lasagna_future.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@
},
"labelAlign": "center",
"labelBaseline": "top",
"zindex": 0
"zindex": 1
},
{"scale": "y", "orient": "left", "grid": false, "zindex": 0}
{"scale": "y", "orient": "left", "grid": false, "zindex": 1}
],
"legends": [
{
Expand Down
Loading

0 comments on commit 2fe10b2

Please sign in to comment.