Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove d3 select. #241

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Remove d3 select. #241

merged 3 commits into from
Oct 9, 2019

Conversation

haldenl
Copy link
Contributor

@haldenl haldenl commented Oct 8, 2019 •
edited
Loading

Replace d3 select with native document functions to lighten package. #212

@haldenl haldenl requested a review from domoritz October 8, 2019 21:24
@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2019

This pull request fixes 1 alert when merging 06d6f7a into c456246 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types

@domoritz domoritz merged commit c38ef3e into master Oct 9, 2019
@domoritz domoritz deleted the remove_select branch October 9, 2019 05:02
@domoritz
Copy link
Member

domoritz commented Oct 9, 2019

Thank you @haldenl

@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2019

This pull request fixes 1 alert when merging f5de8b4 into c456246 - view on LGTM.com

fixed alerts:

  • 1 for Comparison between inconvertible types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz Awaiting requested review from domoritz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haldenl @domoritz