feat: Add new forceActionsMenu embed option #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
forceActionsMenu
embed option that can be used to forcevega-embed
to display actions in a details menu rather than in links even when
defaultStyle
is set tofalse
.If
defaultStyle
is notfalse
or ifactions
isfalse
, the option has no effect.This is useful in cases where the parent application of an embedded vega chart wants to be able to
style the actions menu itself rather than having vega inline a
<style/>
tag to do so (see #1214 fordetails as to why this might be desired). Currently, applications that want to do this have to use a small
hack of setting
defaultStyles
to an empty string rather thanfalse
so that vega still adds the menu(see this code in the streamlit codebase for an example). This change doesn't really change anything
functionally but allows applications to write code that's a bit more clear.