Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update the scaleFactor property to allow setting different values #1051

Merged
merged 4 commits into from
Jan 26, 2023
Merged

feat: update the scaleFactor property to allow setting different values #1051

merged 4 commits into from
Jan 26, 2023

Conversation

joaopalmeiro
Copy link
Contributor

@joaopalmeiro joaopalmeiro commented Jan 20, 2023 •
edited by github-actions bot
Loading

Closes #1047

Hi! 👋

This PR contains my proposal to support a different scaleFactor for each format (PNG and SVG) following conventions for other properties. I also added an HTML file for testing.

What do you think? Let me know your opinion, @domoritz! 😄

Version

Published prerelease version: v6.22.0-next.0

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, João Palmeiro (@joaopalmeiro), for all your work!

🚀 Enhancement

  • feat: update the scaleFactor property to allow setting different values #1051 (@joaopalmeiro)

🐛 Bug Fix

⚠️ Pushed to next

🔩 Dependency Updates

Authors: 3

domoritz
domoritz reviewed Jan 21, 2023
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Do you have an idea for how you could write an actual unit test for this? Maybe at least we can test that setting an object doesn't crash.

@joaopalmeiro
Copy link
Contributor Author

Thank you. Do you have an idea for how you could write an actual unit test for this? Maybe at least we can test that setting an object doesn't crash.

I added a test based on your suggestion. What do you think?

@domoritz
Copy link
Member

Thank you.

@domoritz domoritz merged commit 35be206 into vega:next Jan 26, 2023
@github-actions
Copy link

🚀 PR was released in v6.22.0-next.0 🚀

@joaopalmeiro joaopalmeiro deleted the feat-update-the-scaleFactor-property-to-allow-setting-different-values branch January 26, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz left review comments

Assignees
No one assigned
Labels
prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting the scaleFactor for each format separately
2 participants
@joaopalmeiro @domoritz