-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generate docstrings for mark_
methods
#3675
Conversation
If I recall correctly, not every mark supports the same variable definitions, do you assume here that all marks can use the same |
@mattijn thanks for looking at this so soon!
Just to be sure I understand what you mean, are you referring to this old comment? altair/tools/generate_schema_wrapper.py Lines 920 to 926 in c1e8062
I've interpretted that as meaning how the docs for MarkDef has some descriptions which state they only apply for specific marks (e.g. If so, I don't think there would be a reliable way to do that - since the descriptions aren't written in a consistent style. Or did you mean altair/altair/vegalite/v5/schema/mixins.py Line 698 in c1e8062
altair/altair/vegalite/v5/schema/mixins.py Line 817 in c1e8062
altair/altair/vegalite/v5/schema/mixins.py Line 892 in c1e8062
If so, then yeah these are split out correctly |
I mean the latter. Good to see that the composite marks are still treated differently, but I thought that not all arguments can be used within the standard marks. It seems that it was and will be covered by just the |
Will look at fixing `mixins` after merging #3675
Thanks! |
Appreciate the review thanks @mattijn |
Closes #3262
Description
This PR is a 2-for-1.
mixins.py
from 3500 to 1600 linesWhat I've done here is created a dummy version of each class, where the only difference is the omission of
type
.The dummy is used only for the signature & docstring.
If we used
core.MarkDef
directly, it always displaystype
first.I'm assuming that wouldn't be desirable - since we set that explicitly in the method body
Example
IDE
2024-11-04.19-20-41.mp4
API reference
Remains unchanged