-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: alt.themes
-> alt.theme
#3618
base: main
Are you sure you want to change the base?
Commits on Sep 28, 2024
-
chore: Add notes for change targets
Need a way to make sense of these and start GH threads: - 10 total files - 3 modules named `theme.py` - 2 modules named `__init__.py`
Configuration menu - View commit details
-
Copy full SHA for 54e7e48 - Browse repository at this point
Copy the full SHA 54e7e48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66c51c3 - Browse repository at this point
Copy the full SHA 66c51c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 754f665 - Browse repository at this point
Copy the full SHA 754f665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dd9100 - Browse repository at this point
Copy the full SHA 3dd9100View commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b1be633 - Browse repository at this point
Copy the full SHA b1be633View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bd8f75 - Browse repository at this point
Copy the full SHA 0bd8f75View commit details -
Configuration menu - View commit details
-
Copy full SHA for c996c95 - Browse repository at this point
Copy the full SHA c996c95View commit details -
Configuration menu - View commit details
-
Copy full SHA for c286c38 - Browse repository at this point
Copy the full SHA c286c38View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef9b846 - Browse repository at this point
Copy the full SHA ef9b846View commit details -
Was dependent on `v5` having the registry exported in `__init__`
Configuration menu - View commit details
-
Copy full SHA for e8d3062 - Browse repository at this point
Copy the full SHA e8d3062View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7fe38b - Browse repository at this point
Copy the full SHA f7fe38bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a1c8d3 - Browse repository at this point
Copy the full SHA 0a1c8d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05eca89 - Browse repository at this point
Copy the full SHA 05eca89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 217d7fb - Browse repository at this point
Copy the full SHA 217d7fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5078f88 - Browse repository at this point
Copy the full SHA 5078f88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2339116 - Browse repository at this point
Copy the full SHA 2339116View commit details
Commits on Sep 30, 2024
-
refactor: Refine and fully document
generate_schema__init__
- Require fewer parameters - Remove need for format string - Adds general `path_to_module_str` utility #3618 (comment)
Configuration menu - View commit details
-
Copy full SHA for 48e44c0 - Browse repository at this point
Copy the full SHA 48e44c0View commit details -
refactor: Use new functions for part of
update__all__variable
The rest is still different enough that I'm not planning to further generalize between the two approaches
Configuration menu - View commit details
-
Copy full SHA for a7dbaca - Browse repository at this point
Copy the full SHA a7dbacaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0947f8 - Browse repository at this point
Copy the full SHA a0947f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e9f639 - Browse repository at this point
Copy the full SHA 1e9f639View commit details -
docs: Add link targets for API Reference sections
I've paired these with the `toctree` name, except for `api`. Since that would be `api-api`
Configuration menu - View commit details
-
Copy full SHA for d895447 - Browse repository at this point
Copy the full SHA d895447View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9538bc - Browse repository at this point
Copy the full SHA a9538bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e114493 - Browse repository at this point
Copy the full SHA e114493View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8033b2 - Browse repository at this point
Copy the full SHA c8033b2View commit details -
refactor: Remove unused
__future__
importI added this while experimenting with a more complex `__getattr__`, but don't need it for anything in this version
Configuration menu - View commit details
-
Copy full SHA for ef0f263 - Browse repository at this point
Copy the full SHA ef0f263View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 58da996 - Browse repository at this point
Copy the full SHA 58da996View commit details -
fix(typing): Partial resolve
mypy
__getattr__
Didn't have any issues with `pyright`. Adapted from https://stackoverflow.com/a/78369397 https://github.com/vega/altair/actions/runs/11123634307/job/30907482239?pr=3618
Configuration menu - View commit details
-
Copy full SHA for bc507a9 - Browse repository at this point
Copy the full SHA bc507a9View commit details -
test: Rename test to
test_theme_register_decorator
Now reflects the updated function name
Configuration menu - View commit details
-
Copy full SHA for e0f4721 - Browse repository at this point
Copy the full SHA e0f4721View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e8def0 - Browse repository at this point
Copy the full SHA 4e8def0View commit details -
test: Add
test_theme_unregister
The commented out assertion may be added later after resolving #3619
Configuration menu - View commit details
-
Copy full SHA for 9bd0316 - Browse repository at this point
Copy the full SHA 9bd0316View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d95b44 - Browse repository at this point
Copy the full SHA 0d95b44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e6bde8 - Browse repository at this point
Copy the full SHA 3e6bde8View commit details
Commits on Oct 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6141c7c - Browse repository at this point
Copy the full SHA 6141c7cView commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1ae98e - Browse repository at this point
Copy the full SHA d1ae98eView commit details
Commits on Oct 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2ca4b11 - Browse repository at this point
Copy the full SHA 2ca4b11View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d3dccab - Browse repository at this point
Copy the full SHA d3dccabView commit details
Commits on Oct 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c49b51 - Browse repository at this point
Copy the full SHA 7c49b51View commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a3e2d28 - Browse repository at this point
Copy the full SHA a3e2d28View commit details -
Configuration menu - View commit details
-
Copy full SHA for a018165 - Browse repository at this point
Copy the full SHA a018165View commit details
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98f4ed3 - Browse repository at this point
Copy the full SHA 98f4ed3View commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fe4321 - Browse repository at this point
Copy the full SHA 4fe4321View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2b3eb35 - Browse repository at this point
Copy the full SHA 2b3eb35View commit details -
Rather than saying exactly where `name` is **stored**, showing a place it is **used** with an example
Configuration menu - View commit details
-
Copy full SHA for 10872b6 - Browse repository at this point
Copy the full SHA 10872b6View commit details -
docs: Update
customization.rst
- Replaced references to `altair.theme.themes` - Tried to improve the flow, without entirely removing the term "registry"
Configuration menu - View commit details
-
Copy full SHA for 1127534 - Browse repository at this point
Copy the full SHA 1127534View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb56c82 - Browse repository at this point
Copy the full SHA cb56c82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0977228 - Browse repository at this point
Copy the full SHA 0977228View commit details
Commits on Oct 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5a1dc68 - Browse repository at this point
Copy the full SHA 5a1dc68View commit details -
"` to all deprecation warnings #3618 (comment), #3618 (comment)
Configuration menu - View commit details
-
Copy full SHA for 22d7df2 - Browse repository at this point
Copy the full SHA 22d7df2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25cbdc8 - Browse repository at this point
Copy the full SHA 25cbdc8View commit details
Commits on Oct 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e29a2f7 - Browse repository at this point
Copy the full SHA e29a2f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0497e0 - Browse repository at this point
Copy the full SHA a0497e0View commit details -
docs: Add more specific constraints to
@deprecated_static_only
The rules here are not the same as the rules for [`LiteralString`](https://typing.readthedocs.io/en/latest/spec/literal.html#literalstring) Hoping to avoid any confusion if anyone uses this later
Configuration menu - View commit details
-
Copy full SHA for b84fd5f - Browse repository at this point
Copy the full SHA b84fd5fView commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf11ec1 - Browse repository at this point
Copy the full SHA bf11ec1View commit details
Commits on Oct 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for afcd1b9 - Browse repository at this point
Copy the full SHA afcd1b9View commit details