-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Reduce SchemaValidationError
traceback length
#3530
refactor: Reduce SchemaValidationError
traceback length
#3530
Commits on Aug 8, 2024
-
refactor: Move comment to
SchemaValidationError.__init__
No information is lost, still available on hover. The comment itself is not helpful to users and would be presented on every validation error
Configuration menu - View commit details
-
Copy full SHA for 8aa59d8 - Browse repository at this point
Copy the full SHA 8aa59d8View commit details -
docs: Reduce repetition and rearrange
SchemaBase.to_dict
Moved repeat info to *Notes*, which should come last https://numpydoc.readthedocs.io/en/latest/format.html#notes Removed redundant *Returns* Minor changes to improve readability
Configuration menu - View commit details
-
Copy full SHA for 1f60847 - Browse repository at this point
Copy the full SHA 1f60847View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b0a03 - Browse repository at this point
Copy the full SHA 90b0a03View commit details -
refactor: Use
genexpr
instead ofdictcomp
Saves 2 lines, identical result, maybe faster due to not allocating an intermediate dict
Configuration menu - View commit details
-
Copy full SHA for f700cff - Browse repository at this point
Copy the full SHA f700cffView commit details -
refactor: Use ternary exprs for
context
,ignore
All `...ChannelMixin` already use this form. Saves 2 lines
Configuration menu - View commit details
-
Copy full SHA for 0c2e216 - Browse repository at this point
Copy the full SHA 0c2e216View commit details -
refactor: Alias
kwds
filter toexclude
Saves only 1 line, but collapses the dict comp. The `:=` expr doesn't reduce lines, but does reduce characters
Configuration menu - View commit details
-
Copy full SHA for 7a121df - Browse repository at this point
Copy the full SHA 7a121dfView commit details -
refactor: Call
_to_dict
from a single siteSaves 2 lines, avoids repeating the 3 kwargs - but allows modified `context`
Configuration menu - View commit details
-
Copy full SHA for 502140b - Browse repository at this point
Copy the full SHA 502140bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fca2e62 - Browse repository at this point
Copy the full SHA fca2e62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01a8ae3 - Browse repository at this point
Copy the full SHA 01a8ae3View commit details -
refactor: Factor out large block to
_replace_parsed_shorthand
As with the change to `SchemaValidationError`, the information is available in a docstring if needed. But no longer is displayed to the user on a validation error
Configuration menu - View commit details
-
Copy full SHA for 4943c34 - Browse repository at this point
Copy the full SHA 4943c34View commit details
Commits on Aug 9, 2024
-
refactor: Factor out optional imports to
_get_optional_modules
Removes 5 lines. Has the additional benefit of replacing an identical block in `SchemaBase.validate_property`. Therefore reduces the maintenance burden of keeping comments in sync
Configuration menu - View commit details
-
Copy full SHA for 44d2873 - Browse repository at this point
Copy the full SHA 44d2873View commit details -
feat(typing): Update
api._top_schema_base
to work with `super(..., ……copy)` The call to `.to_dict`, and 3 line comment also appeared in the traceback for validation errors on `ChartType`s. This removes the need for the comment and type ignore that it is describing. See vega#3480 for more info on the introduction of `_top_schema_base`
Configuration menu - View commit details
-
Copy full SHA for 1a51948 - Browse repository at this point
Copy the full SHA 1a51948View commit details -
fix: Use class name instead of metaclass name in error
Discovered during debugging that the rhs always evaluated as `type`, which was not intentional
Configuration menu - View commit details
-
Copy full SHA for 48162ed - Browse repository at this point
Copy the full SHA 48162edView commit details -
docs: Propagate
to_dict
changes tofrom_dict
,to_json
Just to keep things consistent
Configuration menu - View commit details
-
Copy full SHA for 788dca4 - Browse repository at this point
Copy the full SHA 788dca4View commit details -
docs: Propagate changes to
api.(TopLevelMixin|Chart)
Should achieve greater consistency across the public API
Configuration menu - View commit details
-
Copy full SHA for b86bd2f - Browse repository at this point
Copy the full SHA b86bd2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7f6ac2 - Browse repository at this point
Copy the full SHA f7f6ac2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16e70d3 - Browse repository at this point
Copy the full SHA 16e70d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cae615 - Browse repository at this point
Copy the full SHA 0cae615View commit details
Commits on Aug 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8462279 - Browse repository at this point
Copy the full SHA 8462279View commit details
Commits on Aug 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for abb3d76 - Browse repository at this point
Copy the full SHA abb3d76View commit details
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed0f872 - Browse repository at this point
Copy the full SHA ed0f872View commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d8c25b9 - Browse repository at this point
Copy the full SHA d8c25b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39969e3 - Browse repository at this point
Copy the full SHA 39969e3View commit details
Commits on Aug 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b5625fd - Browse repository at this point
Copy the full SHA b5625fdView commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for df788b0 - Browse repository at this point
Copy the full SHA df788b0View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f8a59c6 - Browse repository at this point
Copy the full SHA f8a59c6View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7356e67 - Browse repository at this point
Copy the full SHA 7356e67View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b42364b - Browse repository at this point
Copy the full SHA b42364bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf7d5e5 - Browse repository at this point
Copy the full SHA bf7d5e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 481790c - Browse repository at this point
Copy the full SHA 481790cView commit details
Commits on Aug 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae8ee45 - Browse repository at this point
Copy the full SHA ae8ee45View commit details