feat: Upgrade Vega-Lite from 5.17.0 to 5.19.0 #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmease
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Setting "request changes" to flag that vl-convert doesn't support Vega-Lite 5.19.0 yet.
See #3478 (comment)
|
Oh, good point! I somehow stopped half-way through the instructions, sorry for that :) I've now also bumped the version used in JupyterChart. |
jonmmease
approved these changes
Jul 17, 2024
|
Oh, actually, I think we still need to update the vl-convert version in the importer here: altair/altair/utils/_importers.py Line 44 in 9afd374 |
|
I've now updated the vl-convert version in |
|
Is this issue now appearing #3447? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit, I only changed the version number and ran the code generation. The other commits are manual changes.