Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use importlib.metadata and packaging instead of deprecated pkg_resources #3133

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

binste
Copy link
Contributor

@binste binste commented Aug 1, 2023

Closes #3132

Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking nit and one non-blocking question inline. Thanks for taking care of this!

@binste binste merged commit 157c4e3 into vega:main Aug 1, 2023
@binste
Copy link
Contributor Author

binste commented Aug 1, 2023

Thanks for the review!

sacundim pushed a commit to sacundim/covid-19-puerto-rico that referenced this pull request Aug 2, 2023
@sacundim
Copy link

sacundim commented Aug 2, 2023

As I mention in the issue, I serendipitously just happened today to land on a circumstance where this deprecation breaks the app, and I have actually just confirmed that this PR fixes the issue.

The way to trigger the issue this fixes was to run in a virtualenv that lacks the pip, setuptools and wheel packages—one of those (I didn't quite work out which) is the one that supplies the pkg_resources module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_resources is deprecated
3 participants