Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deep validation and instead use error hierarchy to improve error messages #2842

Merged
merged 11 commits into from
Feb 5, 2023
Merged

Remove deep validation and instead use error hierarchy to improve error messages #2842

merged 11 commits into from
Feb 5, 2023

Commits on Jan 20, 2023

  1. Remove SchemaValidationError._get_contents as it's no longer required… 

    … in jsonschema 2.3 or later. Altair requires > 3
    @binste
    binste committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    697a682 View commit details
    Browse the repository at this point in the history

  2. Instead of deep validation, use the error hierarchy from the jsonsche… 

    …ma package to build more informative error messages
    @binste
    binste committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    a5d263a View commit details
    Browse the repository at this point in the history

  3. Remove leftovers from deep validation

    @binste
    binste committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    feb889b View commit details
    Browse the repository at this point in the history

  4. Fix warnings in tests

    @binste
    binste committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    be092b9 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Merge branch 'master' into improve_error_messages

    @binste
    binste committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    f47eac5 View commit details
    Browse the repository at this point in the history

  2. Fix type in docstring of validate in to_json

    @binste
    binste committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e9b913f View commit details
    Browse the repository at this point in the history

  3. Rewrite lambda functions as normal functions

    @binste
    binste committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    1e68cc9 View commit details
    Browse the repository at this point in the history

  4. Remove validate from _todict

    @binste
    binste committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    cfb80d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Update tests/utils/tests/test_schemapi.py 

    Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
    @binste @joelostblom
    binste and joelostblom authored Feb 5, 2023
    Configuration menu
    Copy the full SHA
    70c1131 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into improve_error_messages

    @binste
    binste committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    85f3c91 View commit details
    Browse the repository at this point in the history

  3. Add PR to changelog

    @binste
    binste committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    41c3f03 View commit details
    Browse the repository at this point in the history