Remove side-effects of calling EncodingChannelMixin.to_dict #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanging chart representations after displaying them
binste
force-pushed
the
remove_sideeffects_of_to_dict
branch
from
8346003 to
05b52b7
Compare
joelostblom
reviewed
Jan 8, 2023
There was a problem hiding this comment.
Looks great, thank you for tackling this issue! To prevent this regressing in the future, could we add a test that checks that the chart spec contains the shorthand syntax and that it is expanded to the long form syntax when using to.dict(), both before and after displaying (or equivalent) a chart?
|
Sure! Done :) |
joelostblom
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2497. CC @joelostblom. It can be verified by using the example code in the mentioned issue.