-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#2675): replace entrypoints with importlib.metadata #2686
Conversation
Ah! Tested locally with 3.10 and 3.6. Missed that the selection interface was added in 3.10. I'll update this to parse the dict from |
ee7d22c
to
bdeecbf
Compare
Thanks for the PR @daylinmorgan! Can you synchronize this PR with the latest changes on master? Hopefully @joelostblom can do a review here. |
bdeecbf
to
e2c77bb
Compare
This has been rebased on master. PR drops unnecessary (and the now in maintenance mode) |
Thanks @daylinmorgan! |
The entrypoints I'm aware of are in |
Thanks! It is out of scope of this PR, but it seems the entry points in these packages also require updating once Altair is going to vegalite 5. The entry points should become Again out of scope, but I'm wondering if it already breaks on the main repo of Altair if a specific VL5 spec is parsed through these entry points. I'm fine with this PR, you also @joelostblom? |
Thank you @daylinmorgan! |
As mentioned in #2675,
entrypoints
is now in maintenance mode. We can replace it withimportlib.metadata
and remove the extra dependency forpython < 3.8
.