MAINT: Replace iteritems with items
#2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2022
|
@mattijn This seems to be a harmless change to me, do you think we can merge this PR? |
4 tasks
mattijn
pushed a commit
that referenced
this pull request
Jan 20, 2023
* DOC: remove unused section * Disable uri-reference format check in jsonsschema (#2771) * Disable uri-reference format check. Consistently use same validator across codebase * Remove validation in SchemaInfo as not used anywhere and it referenced the wrong jsonschema draft * Add compatibility for older jsonschema versions * Improve comments * Simplify validate_jsonschema * Replace `iteritems` with `items` due to pandas deprecation (#2683) * Add changelog entry. * Bump version. * Run black and flake8. * Pin selenium in CI. Co-authored-by: Jake VanderPlas <jakevdp@google.com> Co-authored-by: Stefan Binder <binder_stefan@outlook.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
mattijn
pushed a commit
to mattijn/altair
that referenced
this pull request
Jan 21, 2023
* DOC: remove unused section * Disable uri-reference format check in jsonsschema (vega#2771) * Disable uri-reference format check. Consistently use same validator across codebase * Remove validation in SchemaInfo as not used anywhere and it referenced the wrong jsonschema draft * Add compatibility for older jsonschema versions * Improve comments * Simplify validate_jsonschema * Replace `iteritems` with `items` due to pandas deprecation (vega#2683) * Add changelog entry. * Bump version. * Run black and flake8. * Pin selenium in CI. Co-authored-by: Jake VanderPlas <jakevdp@google.com> Co-authored-by: Stefan Binder <binder_stefan@outlook.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
mattijn
added a commit
that referenced
this pull request
Jan 21, 2023
* include an altairfuturewarning * deprecate vega 5 wrappers and render function * deprecate vegalite 3 wrappers and render function * use AltairDeprecationWarning * fix typo in v5 warning * remove mentioning alternative for vega wrappers * Backport bug fixes for a 4.2.1 release (#2827) * DOC: remove unused section * Disable uri-reference format check in jsonsschema (#2771) * Disable uri-reference format check. Consistently use same validator across codebase * Remove validation in SchemaInfo as not used anywhere and it referenced the wrong jsonschema draft * Add compatibility for older jsonschema versions * Improve comments * Simplify validate_jsonschema * Replace `iteritems` with `items` due to pandas deprecation (#2683) * Add changelog entry. * Bump version. * Run black and flake8. * Pin selenium in CI. Co-authored-by: Jake VanderPlas <jakevdp@google.com> Co-authored-by: Stefan Binder <binder_stefan@outlook.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com> * include note in releases change log Co-authored-by: Jan Tilly <jan.tilly@quantco.com> Co-authored-by: Jake VanderPlas <jakevdp@google.com> Co-authored-by: Stefan Binder <binder_stefan@outlook.com> Co-authored-by: Joel Ostblom <joelostblom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iteritemsis raising a warning in pandas >=1.5 as it is now deprecated. The recommended replacement isitems.