Tidy line chart examples #2644
Merged
Tidy line chart examples #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think these additional examples are useful! Could we change the dataset in all these examples to the stocks data instead so that the axis can be temporal instead of ordinal? It looks like this is what they have done in the Vega-Lite repo as well https://vega.github.io/vega-lite/examples/#line-charts for the corresponding line charts. |
Merged
|
Alright. I think a good chunk of what we had here was handled upstream. But, FWIW, I think what remains is still worth merging. |
joelostblom
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is a revival of #1284, which lost its downstream fork and had conflicts requiring resolution. I believe it is ready now for reconsideration.
I've added two new line chart examples lifted from the ones upstream in the Vega Lite docs. In the interest of uniformity, I also modified two existing examples to ensure that they all are drawn from the same datasets as complimentary examples, which will make things quicker to grok for newbies.