Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Make the schema validation error for non-existing params more informative #2568

Merged
merged 27 commits into from
Feb 21, 2023
Merged

ENH: Make the schema validation error for non-existing params more informative #2568

merged 27 commits into from
Feb 21, 2023

Commits on Jan 8, 2023

  1. Make the schema validation error for non-existing params more informa… 

    …tive
    @joelostblom
    joelostblom committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    555a6c2 View commit details
    Browse the repository at this point in the history

  2. Neatly format the existing params as a table

    @joelostblom
    joelostblom committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    430b17b View commit details
    Browse the repository at this point in the history

  3. Use more reliable way of returning the non-existing param name 

    My original approach sometimes returned the name of an existing
parameter. This commit uses the same approach as the fallback but
extracts just the parameter name from the message string.
    @joelostblom
    joelostblom committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    45f11b6 View commit details
    Browse the repository at this point in the history

  4. Break out table formatting into its own function

    @joelostblom
    joelostblom committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    95b1c60 View commit details
    Browse the repository at this point in the history

  5. Add changes into code generation file

    @joelostblom
    joelostblom committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    9bd738b View commit details
    Browse the repository at this point in the history

  6. Remove mistakingly added old lines

    @joelostblom
    joelostblom committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    4eeac63 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge branch 'master' into schema-validation-error

    @joelostblom
    joelostblom authored Feb 5, 2023
    Configuration menu
    Copy the full SHA
    8dbf794 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Merge branch 'altair-viz:master' into schema-validation-error

    @joelostblom
    joelostblom authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    3a41601 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Only show existing parameters if an unknown parameter was used

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f994245 View commit details
    Browse the repository at this point in the history

  2. Update tests to check for detailed parameter errors

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    bee7b8b View commit details
    Browse the repository at this point in the history

  3. Trim error messages to be more to the point by removing unhelpful info

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    4395f58 View commit details
    Browse the repository at this point in the history

  4. Add a general heading to error messages with multiple errors so that … 

    …they work nicely with the cmopressed error message format
    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    8848228 View commit details
    Browse the repository at this point in the history

  5. Remove "self" from listed params

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    1ce2bcf View commit details
    Browse the repository at this point in the history

  6. Blake format and use cleandoc for proper indendation in the source

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    31948e8 View commit details
    Browse the repository at this point in the history

  7. Update old test message to remove what is no longer in the error message

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    750bfd1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into schema-validation-error

    @joelostblom
    joelostblom authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    946ca90 View commit details
    Browse the repository at this point in the history

  9. Move invalid y option tests next to each other

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    8e9e7c7 View commit details
    Browse the repository at this point in the history

  10. Black format

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7a89d76 View commit details
    Browse the repository at this point in the history

  11. Update test to account for missing self

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    01c517f View commit details
    Browse the repository at this point in the history

  12. Refine the message construction and move it to the else clause where … 

    …it will be used
    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    f9b4f3b View commit details
    Browse the repository at this point in the history

  13. Remove flake8 test for multline line strings with trailing whitespace

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    3718432 View commit details
    Browse the repository at this point in the history

  14. Add latest updates to source generator file as well

    @joelostblom
    joelostblom committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    3022f8c View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Merge branch 'master' into schema-validation-error

    @joelostblom
    joelostblom authored Feb 19, 2023
    Configuration menu
    Copy the full SHA
    33296b0 View commit details
    Browse the repository at this point in the history

  2. Remove redundant schema_path variable and allow unknown encodings par… 

    …ams to trigger the parameter table

Co-authored-by: Stefan Binder <binder_stefan@outlook.com>
    @joelostblom @binste
    joelostblom and binste committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b994959 View commit details
    Browse the repository at this point in the history

  3. Remove redundant assert

    @joelostblom
    joelostblom committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    afd614b View commit details
    Browse the repository at this point in the history

  4. Add latest updates to source generator file as well

    @joelostblom
    joelostblom committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    4e8bac5 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Include changes to tests in tools code generation file

    @joelostblom
    joelostblom committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    187c817 View commit details
    Browse the repository at this point in the history