Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plot yaxis2 #383

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Feature/plot yaxis2 #383

merged 4 commits into from
Sep 5, 2024

Conversation

cortex
Copy link
Contributor

@cortex cortex commented Sep 5, 2024

Some enhancements to #382:

  • Separate checkboxes for Y1 and Y1 instead of Plot and Y2
  • Performance fixes

Checking one will uncheck the other
Previous version made one event handler lambda for each row, causing
bad performance
* Don't update graph when name/value column changes (done on click)
* Use named column indices
* Compute currentRow once in addDataItem
@cortex cortex marked this pull request as draft September 5, 2024 09:57
@vedderb vedderb marked this pull request as ready for review September 5, 2024 10:21
@vedderb vedderb merged commit 1ea085d into vedderb:master Sep 5, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants