-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update civix templates #520
Conversation
@totten What is the minimum CiviCRM core version requirement for this? |
@mattwire I've tested the civix updates generally on 5.39, 5.44, 5.45, and master. Since (ED: And I would expect compat further back, but I haven't tested further back.) |
@totten as you noted, Mosaico's current |
Correct, they're not required. But I'm ambivalent. There's no runtime cost (CPU/RAM), though there is a passive-storage cost (disk-space). The practice of curating those files also has a cost -- one has to think about the compatibility-matrix and decide when/whether to commit each. Comparing the size of the files against the curation cost... I don't think it's really worthwhile to fine-tune the list in specific extensions. I'd go for commit+forget. Of course... from a systemic POV... things do a add-up. It be better if |
I think the |
The implementation of `hook_angularModules` had a funny guard at the top, and it becomes inoperative when switching to `ang-php` mixin. This reinstates the filter.
Updated again with 22.05.2. This removes the backport files. |
@@ -373,6 +324,7 @@ function mosaico_civicrm_mailingTemplateTypes(&$types) { | |||
* Implements hook_civicrm_entityTypes(). | |||
*/ | |||
function mosaico_civicrm_entityTypes(&$entityTypes) { | |||
// _mosaico_civix_civicrm_entityTypes($entityTypes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary addition.
I don't have merge rights to this repo but 👍 for merging. |
See also: https://civicrm.org/blog/totten/civix-v2205-how-remove-million-lines-extra-code