Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels can't be read when they're long #630

Closed
artfulrobot opened this issue Jan 18, 2024 · 15 comments
Closed

Labels can't be read when they're long #630

artfulrobot opened this issue Jan 18, 2024 · 15 comments

Comments

@artfulrobot
Copy link
Contributor

Anyone using Mosaico Message Templates will have long titles for the templates because they combine the template name and the message subject.

But others may reasonably have longer titles too.

This makes the select template display unworkable/unreadable:

image

Possibly related: #526

@artfulrobot
Copy link
Contributor Author

artfulrobot commented Jan 18, 2024

I have CSS changes to suggest but can't figure out how you compile your SASS?

$ npm install
up to date, audited 676 packages in 5s
...
$ gulp sass
[20:02:44] Working directory changed to .
AssertionError [ERR_ASSERTION]: Task function must be specified
    at Gulp.set [as _setTask] (./node_modules/undertaker/lib/set-task.js:10:3)
    at Gulp.task (./node_modules/undertaker/lib/task.js:1
3:8)
    at ./gulpfile.js:20:8
    at Object.<anonymous> (./gulpfile.js:84:2)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

@mattwire
Copy link
Collaborator

@artfulrobot sass hasn't been compiled for 2 years so it's quite likely that the npm/gulp toolchain has broken in that regard :-(

@artfulrobot
Copy link
Contributor Author

@mattwire yeah I fought it for an hour and got nowhere. Gulp.

But have made a PR the ol' fashioned way.

mattwire added a commit that referenced this issue Jan 19, 2024
Css, html fixes for selecting a template #630
@composerjk
Copy link

In Mosaico 3.4, template labels seem worse. Looking at wpmaster.demo.civicrm.org and dmaster.demo.civicrm.org:

image

Originally noted on Mattermost with CiviCRM 5.70.1.

@artfulrobot
Copy link
Contributor Author

@composerjk This looks odd. The change I brought moves labels to the side (so they can be longer) - see screenshot at: #631

so if your labels are at the bottom then either that PR isn't included in 3.4 or something else is wrong.

What theme(s) are you using?

@BeccaTregenna
Copy link

@artfulrobot we see the same as @composerjk on 3.4 both with Radstock and The Island

@artfulrobot
Copy link
Contributor Author

artfulrobot commented Feb 28, 2024

@composerjk @BeccaTregenna what CMS? And, never heard of radstock - got a link?

@BeccaTregenna
Copy link

Both on WordPress and I think Radstock comes with Civi Admin Utilities

@composerjk
Copy link

@artfulrobot That screenshot came from https://wpmaster.demo.civicrm.org

@artfulrobot
Copy link
Contributor Author

I'll fix this

@artfulrobot
Copy link
Contributor Author

artfulrobot commented Feb 29, 2024

Fixed, I believe, please see #638

@BeccaTregenna I installed WordPress + installed the Admin Utils WP Plugin, but I couldn't see Radstock in the CiviCRM's theme options under Display Preferences? So I couldn't test that. EDIT: found it. See link above for screenshot

@BeccaTregenna
Copy link

Thank you @artfulrobot, it's much appreciated. I suspect I was wrong about Radstock, will check with @kurund

@artfulrobot
Copy link
Contributor Author

@BeccaTregenna ah found it, just have to enable it a different way. All should be good - see the PR link for screenshots

@artfulrobot
Copy link
Contributor Author

PR Link, #638

@composerjk
Copy link

Cool, thanks! Look forward to it being merged with a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants