Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RED7114 display only public groups in GDPR tab #54

Merged

Conversation

mathavanveda
Copy link
Collaborator

No description provided.

@tbuytaer
Copy link
Contributor

#61 Would it be a good idea to add a checkbox "Public groups only"? This checkbox can be checked by default.
This way people have the option to display the subscription history of all the groups.

@tbuytaer
Copy link
Contributor

If we limit this to g.is_active = 1, we won't be able to see the history of groups that are no longer active, but that the Contact belonged to in the past.

If Alice was subscribed to groups "Super Fun Newsletter" and we stop sending that newsletter and deactivate the group, shouldn't we still be able to see that Alice used to be in that group, and when she was added and removed?

@veda-consulting
Copy link
Member

@tbuytaer sure, I was thinking the same thing. We will add a switch.

@veda-consulting veda-consulting merged commit fe3e511 into veda-consulting-company:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants